Merge eaf006e into 08e82f7

jeremydaly · Jun 14, 2021 · 53508c7 · 53508c7
2 parents 08e82f7 + eaf006e
commit 53508c7
Show file tree

Hide file tree

Showing 9 changed files with 715 additions and 239 deletions.
diff --git a/src/__tests__/entity.delete.unit.test.ts b/src/__tests__/entity.delete.unit.test.ts
@@ -45,7 +45,6 @@ describe('delete', () => {
   })
 
   it('deletes the key from inputs (async)', async () => {
-    // @ts-expect-error 💥 TODO: Fix return type
     const { TableName, Key } = await TestEntity.delete({ email: 'test-pk', sort: 'test-sk' })
     expect(TableName).toBe('test-table')
     expect(Key).toEqual({ pk: 'test-pk', sk: 'test-sk' })
@@ -63,7 +62,6 @@ describe('delete', () => {
   })
 
   it('filters out extra data (async)', async () => {
-    // @ts-expect-error 💥 TODO: Fix return type
     let { TableName, Key } = await TestEntity.delete({
       email: 'test-pk',
       sort: 'test-sk',
@@ -82,7 +80,7 @@ describe('delete', () => {
   })
 
   it('coerces key values to correct types (async)', async () => {
-    // @ts-expect-error 💥 TODO: Fix return type + Support coerce keyword
+    // @ts-expect-error 💥 TODO: Support coerce keyword
     let { TableName, Key } = await TestEntity.delete({ email: 1, sort: true })
     expect(TableName).toBe('test-table')
     expect(Key).toEqual({ pk: '1', sk: 'true' })

diff --git a/src/__tests__/entity.get.unit.test.ts b/src/__tests__/entity.get.unit.test.ts
@@ -45,7 +45,6 @@ describe('get', () => {
   })
 
   it('gets the key from inputs (async)', async () => {
-    // @ts-expect-error 💥 TODO: Correct interface ?
     const { TableName, Key } = await TestEntity.get({ email: 'test-pk', sort: 'test-sk' })
     expect(TableName).toBe('test-table')
     expect(Key).toEqual({ pk: 'test-pk', sk: 'test-sk' })
@@ -63,7 +62,6 @@ describe('get', () => {
   })
 
   it('filters out extra data (async)', async () => {
-    // @ts-expect-error 💥 TODO: Correct interface ?
     let { TableName, Key } = await TestEntity.get({
       email: 'test-pk',
       sort: 'test-sk',
@@ -82,7 +80,7 @@ describe('get', () => {
   })
 
   it('coerces key values to correct types (async)', async () => {
-    // @ts-expect-error 💥 TODO: Correct interface ? + Support coerce keyword
+    // @ts-expect-error 💥 TODO: Support coerce keyword
     let { TableName, Key } = await TestEntity.get({ email: 1, sort: true })
     expect(TableName).toBe('test-table')
     expect(Key).toEqual({ pk: '1', sk: 'true' })

diff --git a/src/__tests__/entity.utils.unit.test.ts b/src/__tests__/entity.utils.unit.test.ts
@@ -0,0 +1,24 @@
+import { shouldExecute, shouldParse } from '../classes/Entity'
+
+describe('Entity - utils', () => {
+  it('should execute', () => {
+    expect(shouldExecute(true, true)).toBe(true)
+    expect(shouldExecute(true, false)).toBe(true)
+    expect(shouldExecute(undefined, true)).toBe(true)
+  })
+  it('should not execute', () => {
+    expect(shouldExecute(false, false)).toBe(false)
+    expect(shouldExecute(undefined, false)).toBe(false)
+    expect(shouldExecute(false, true)).toBe(false)
+  })
+  it('should parse', () => {
+    expect(shouldParse(true, true)).toBe(true)
+    expect(shouldParse(true, false)).toBe(true)
+    expect(shouldParse(undefined, true)).toBe(true)
+  })
+  it('should not parse', () => {
+    expect(shouldParse(false, false)).toBe(false)
+    expect(shouldParse(undefined, false)).toBe(false)
+    expect(shouldParse(false, true)).toBe(false)
+  })
+})
diff --git a/src/__tests__/parseMapping.unit.test.ts b/src/__tests__/parseMapping.unit.test.ts
@@ -128,7 +128,6 @@ describe('parseMapping', () => {
   })
 
   it('parses partitionKey as string', async () => {
-    // @ts-expect-error 💥 TODO: Support GSIs
     expect(parseMapping('attr', { type: 'string', partitionKey: 'GSI' }, track)).toEqual({
       attr: { type: 'string', partitionKey: 'GSI', coerce: true }
     })
@@ -178,7 +177,6 @@ describe('parseMapping', () => {
     expect(() => {
       parseMapping(
         'attr',
-        // @ts-expect-error 💥 TODO: Support GSIs
         { type: 'string', partitionKey: 'GSI' },
         Object.assign({}, track, { keys: { GSI: { partitionKey: 'GSIpk' } } })
       )
@@ -200,7 +198,6 @@ describe('parseMapping', () => {
     expect(() => {
       parseMapping(
         'attr',
-        // @ts-expect-error 💥 TODO: Support GSIs
         { type: 'string', sortKey: 'GSI' },
         Object.assign({}, track, { keys: { GSI: { partitionKey: 'attr' } } })
       )