fix bug in undefined check

jeremydaly · Apr 17, 2021 · dcf5ac2 · dcf5ac2
1 parent 72c3e0a
commit dcf5ac2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/__tests__/entity.put.unit.test.ts b/src/__tests__/entity.put.unit.test.ts
@@ -93,8 +93,8 @@ const TestEntity5 = new Entity({
   autoExecute: false,
   attributes: {
     pk: { partitionKey: true },
-    test_required_number: { type: 'number', required: true },
     test_required_boolean: { type: 'boolean', required: true },
+    test_required_number: { type: 'number', required: true },
   },
   table: TestTable2
 })

diff --git a/src/classes/Entity.ts b/src/classes/Entity.ts
@@ -1109,9 +1109,8 @@ class Entity<
 
 
     // Check for required fields
-    Object.keys(required).forEach(field => 
-      required[field] !== undefined && data[field] !== null && data[field] !== undefined
-        && error(`'${field}${this.schema.attributes[field].alias ? `/${this.schema.attributes[field].alias}` : ''}' safasfda is a required field`)
+    Object.keys(required).forEach(field => required[field] !== undefined && (data[field] === undefined || data[field] === null)
+        && error(`'${field}${this.schema.attributes[field].alias ? `/${this.schema.attributes[field].alias}` : ''}' is a required field`)
     ) // end required field check
 
     // Checks for partition and sort keys