Type inference for conditional update

[ajanim]

Looking to run a conditional update based on the existence of a particular attribute. I expect the type of updatedProgress to match the full entity, but the inferred type is an object which only includes SK. The object returned does include all properties (contrary to the type inference).

This version has the correct expected return type.

const { Attributes: updatedProgress } = await ProgressEntity.update(
        {
          PK1,
          PK2,
          SK,
          date,
        },
        {
          conditions: [],
          returnValues: 'ALL_NEW',
        },
      );

This version does not.

const { Attributes: updatedProgress } = await ProgressEntity.update(
        {
          PK1,
          PK2,
          SK,
          date,
        },
        {
          conditions: [
            {
              attr: 'SK',
              exists: true,
            },
          ],
          returnValues: 'ALL_NEW',
        },
      );

[aldebout]

Might be related to #367 @naorpeled

[naorpeled]

Hey @ajanim and @aldebout,
will take a look after finishing #471,
I hope that's okay 🙏

[naorpeled]

I think I found out what the issue is,
started working on a PR that should fix it.
Will continue tomorrow, will keep you guys updated!

[mattes3]

Hi, even in V0.9.2 I still don't get the Attributes type correctly when my update call looks like this:

const result = await UserEntity.update(
                    {
                        id,
                        name,
                        email,
                    },
                    { conditions: { attr: 'pk', exists: false }, returnValues: 'ALL_NEW' },
                );

Is there any news on this?

[dvictory]

Looks like @naorpeled started a draft but didn't finish

[naorpeled]

Hey guys,
will give this a look ASAP.

Sorry for disappearing, had a lot of things to deal with IRL 😢