Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: move to AWS-SDK v3 #471

Merged
merged 76 commits into from Apr 8, 2023
Merged

feat!: move to AWS-SDK v3 #471

merged 76 commits into from Apr 8, 2023

Conversation

naorpeled
Copy link
Collaborator

@naorpeled naorpeled commented Mar 9, 2023 •
edited

No description provided.

@naorpeled naorpeled changed the title feat/move to sdk v3 feat!: move to AWS-SDK v3 Mar 9, 2023
@naorpeled naorpeled marked this pull request as draft March 9, 2023 19:02
@shellscape
Copy link
Collaborator

I just came here tonight to see if this effort was underway :D

Is any help needed on this?

@naorpeled
Copy link
Collaborator Author

naorpeled commented Mar 12, 2023 •
edited

I just came here tonight to see if this effort was underway :D

Is any help needed on this?

Hmm, a code review would be much appreciated once this passes CI

Hoping to be able to resume working on it tomorrow

Thanks!

@shellscape
Copy link
Collaborator

When it's ready I'll check out the branch and run some tests. I have some problems with the bigint feature that was added in our environment where numbers aren't being unwrapped, so I'll check that out on this branch as well.

@naorpeled
Copy link
Collaborator Author

When it's ready I'll check out the branch and run some tests. I have some problems with the bigint feature that was added in our environment where numbers aren't being unwrapped, so I'll check that out on this branch as well.

Perfect, thanks!

@bpred754
Copy link

Hey guys, thanks for moving quickly on this. Is there an ETA for when this will be available to pull from npm?

@naorpeled
Copy link
Collaborator Author

Hey guys, thanks for moving quickly on this. Is there an ETA for when this will be available to pull from npm?

Hey,
unfortunately I didn't have the chance to resume working on this.

Hopefully will get to it this weekend and then I could give a proper ETA imo

1 similar comment
@naorpeled
Copy link
Collaborator Author

Hey guys, thanks for moving quickly on this. Is there an ETA for when this will be available to pull from npm?

Hey,
unfortunately I didn't have the chance to resume working on this.

Hopefully will get to it this weekend and then I could give a proper ETA imo

NimmLor
NimmLor reviewed Mar 17, 2023
View reviewed changes
package.json Show resolved Hide resolved
@naorpeled naorpeled requested a review from eadoking April 2, 2023 20:37
darbio
darbio approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@darbio darbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you 🤓

eadoking
eadoking approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@eadoking eadoking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @naorpeled, approved 👍🏻

@naorpeled
Copy link
Collaborator Author

@jeremydaly @ThomasAribart @shellscape let me know what you think 😎 ❤️

@naorpeled naorpeled merged commit 6873d7e into main Apr 8, 2023
5 checks passed
@naorpeled naorpeled deleted the feat/move-to-sdk-v3 branch April 8, 2023 09:36
@naorpeled naorpeled restored the feat/move-to-sdk-v3 branch April 8, 2023 09:37
naorpeled added a commit that referenced this pull request Apr 8, 2023
@naorpeled
Revert "feat!: move to AWS-SDK v3 (#471)"
daebf25 
This reverts commit 6873d7e.
@naorpeled naorpeled mentioned this pull request Apr 8, 2023
Closed
naorpeled added a commit that referenced this pull request Apr 8, 2023
@naorpeled @deniszatsepin
@eadoking @darbio
feat!: move to AWS-SDK v3 (#471)
3019153 
Co-authored-by: deniszatsepin <denis@zatsepin.me>
Co-authored-by: eadoking <do-send@pm.me>
Co-authored-by: darbio <james@darb.io>
This was referenced Apr 8, 2023
Merged
Merged
Merged
naorpeled added a commit that referenced this pull request Apr 8, 2023
@naorpeled @deniszatsepin
@eadoking @darbio
feat!: move to AWS-SDK v3 (#471)
c1cd6eb 
Co-authored-by: deniszatsepin <denis@zatsepin.me>
Co-authored-by: eadoking <do-send@pm.me>
Co-authored-by: darbio <james@darb.io>
@naorpeled naorpeled mentioned this pull request Apr 8, 2023
Merged
@naorpeled naorpeled mentioned this pull request Apr 21, 2023
Merged
@naorpeled naorpeled mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellscape shellscape shellscape approved these changes

@eadoking eadoking eadoking approved these changes

@darbio darbio darbio approved these changes

@jeremydaly jeremydaly jeremydaly approved these changes

@ThomasAribart ThomasAribart Awaiting requested review from ThomasAribart

@NimmLor NimmLor Awaiting requested review from NimmLor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@naorpeled @shellscape @bpred754 @eadoking @darbio @jeremydaly @NimmLor