Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds query support as discussed in issue #5 #22

Closed
wants to merge 9 commits into from

Conversation

DaKaZ
Copy link

@DaKaZ DaKaZ commented Feb 27, 2020

Complete with tests and the updated readme

Note: this PR needed to add support for basic query definitions to all for proper construction of queries against those indexes. Please see the details in the readme file.

@DaKaZ DaKaZ mentioned this pull request Feb 28, 2020
@DaKaZ
Copy link
Author

DaKaZ commented Feb 29, 2020

Issue #5 resolved by this PR

README.md Outdated
@@ -136,6 +136,7 @@ timestamps | `Boolean` | no | Automatically add and manage `created` and `modifi
created | `string` | no | Override default `created` field name |
modified | `string` | no | Override default `modified` field name |
schema | `object` | yes | Complex type that specifies the schema for the model (see below) |
index | `object` | no | Complex type that specifies the indexs available to the model (see below |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
index | `object` | no | Complex type that specifies the indexs available to the model (see below |
index | `object` | no | Complex type that specifies the indexes available to the model (see below |

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @astuyve! Updated

README.md Outdated
@@ -259,6 +260,19 @@ schema: {
}
```

### Inedexes Defnition
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Inedexes Defnition
### Indexes Definition

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed :)

@jeremydaly
Copy link
Owner

jeremydaly commented Mar 4, 2020

@DaKaZ, I really like the approach you took here! I'm in the process of working on an overhaul of this for v0.2 that treats models more like entities (or facets) atop single table designs. So part of the output processing would be to add the ability to handle multiple ENTITY TYPES and appropriately deconstruct them into their proper mappings.

Because of that, I'm likely not going to merge this into the project directly, but I am definitely going to use your contributions here as part of the next go around. Thank you for this work, it will help me immensely!

Jeremy

@DaKaZ
Copy link
Author

DaKaZ commented Mar 12, 2020

@jeremydaly sounds good. I am looking forward to v0.2 :). Anything I can do to help? DM on twitter: @kaztopia

@DaKaZ
Copy link
Author

DaKaZ commented Apr 5, 2020

@jeremydaly if you are interested.... I just added startKey to the query options to make pagination work with limits 🎉

@jeremydaly
Copy link
Owner

@DaKaZ, thanks again for this contribution, it was helpful for me to get a feel for the overall implementation. I have implemented full query and scan support in v0.2, including projections, filters, and more. This is a feature at the Table level since it can query more than one Entity type.

I'm closing this PR to clean things up, but thanks again for your work on this!

@jeremydaly jeremydaly closed this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants