-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds query support as discussed in issue #5 #22
Conversation
Issue #5 resolved by this PR |
README.md
Outdated
@@ -136,6 +136,7 @@ timestamps | `Boolean` | no | Automatically add and manage `created` and `modifi | |||
created | `string` | no | Override default `created` field name | | |||
modified | `string` | no | Override default `modified` field name | | |||
schema | `object` | yes | Complex type that specifies the schema for the model (see below) | | |||
index | `object` | no | Complex type that specifies the indexs available to the model (see below | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index | `object` | no | Complex type that specifies the indexs available to the model (see below | | |
index | `object` | no | Complex type that specifies the indexes available to the model (see below | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @astuyve! Updated
README.md
Outdated
@@ -259,6 +260,19 @@ schema: { | |||
} | |||
``` | |||
|
|||
### Inedexes Defnition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Inedexes Defnition | |
### Indexes Definition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fixed :)
@DaKaZ, I really like the approach you took here! I'm in the process of working on an overhaul of this for v0.2 that treats models more like entities (or facets) atop single table designs. So part of the output processing would be to add the ability to handle multiple ENTITY TYPES and appropriately deconstruct them into their proper mappings. Because of that, I'm likely not going to merge this into the project directly, but I am definitely going to use your contributions here as part of the next go around. Thank you for this work, it will help me immensely! Jeremy |
@jeremydaly sounds good. I am looking forward to v0.2 :). Anything I can do to help? DM on twitter: @kaztopia |
@jeremydaly if you are interested.... I just added |
@DaKaZ, thanks again for this contribution, it was helpful for me to get a feel for the overall implementation. I have implemented full query and scan support in v0.2, including projections, filters, and more. This is a feature at the I'm closing this PR to clean things up, but thanks again for your work on this! |
Complete with tests and the updated readme
Note: this PR needed to add support for basic query definitions to all for proper construction of queries against those indexes. Please see the details in the readme file.