Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup some TODOs #340

Merged
merged 5 commits into from
Nov 10, 2022
Merged

chore: cleanup some TODOs #340

merged 5 commits into from
Nov 10, 2022

Conversation

naorpeled
Copy link
Collaborator

@naorpeled naorpeled commented Oct 11, 2022 •
edited

  • cleaned batchGet a bit (removed todo and flattened nested conditions)
  • improved error message for an invalid attribute

@naorpeled naorpeled changed the title refactor(classes/table): cleanup some TODOs chore(classes/table): cleanup some TODOs Oct 11, 2022
@naorpeled naorpeled changed the title chore(classes/table): cleanup some TODOs chore: cleanup some TODOs Oct 11, 2022
@naorpeled naorpeled merged commit abca3dc into main Nov 10, 2022
@naorpeled naorpeled deleted the refactor/table/cleanup-todos branch November 10, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasAribart ThomasAribart Awaiting requested review from ThomasAribart

@jeremydaly jeremydaly Awaiting requested review from jeremydaly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@naorpeled