Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(entity): resolve removal of empty arrays when removeNulls is true #412

Merged
merged 4 commits into from
Jan 8, 2023
Merged

fix(entity): resolve removal of empty arrays when removeNulls is true #412

merged 4 commits into from
Jan 8, 2023

Conversation

naorpeled
Copy link
Collaborator

@naorpeled naorpeled commented Jan 7, 2023 •
edited

fixes #410

@naorpeled naorpeled changed the title fix(entity): resolve removal of empty arrays fix(entity): resolve removal of empty arrays when removeNulls is true Jan 7, 2023
@naorpeled naorpeled marked this pull request as ready for review January 7, 2023 01:14
@naorpeled naorpeled requested review from ThomasAribart and jeremydaly and removed request for ThomasAribart January 7, 2023 01:24
@naorpeled naorpeled added the bug Something isn't working label Jan 7, 2023
jeremydaly
jeremydaly approved these changes Jan 8, 2023
View reviewed changes
Copy link
Owner

@jeremydaly jeremydaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@naorpeled naorpeled changed the title fix(entity): resolve removal of empty arrays when removeNulls is true fix(entity): resolve removal of empty arrays when removeNulls is true Jan 8, 2023
@naorpeled naorpeled merged commit 5f8f41e into main Jan 8, 2023
@naorpeled naorpeled deleted the fix/entity/resolve-removal-of-fields branch January 8, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremydaly jeremydaly jeremydaly approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UserEntity.update() a property BUT erase an unrelated attribute
2 participants
@naorpeled @jeremydaly