Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attributes not specified in entity to be passed through #53

Merged
merged 4 commits into from
Jul 10, 2020

Conversation

omichowdhury
Copy link
Contributor

@omichowdhury omichowdhury commented May 29, 2020

Fixes #50

Looking at the code I figured this was a bug, since there were guards for everything else.

PS. Thanks for this library, truly makes single table design approachable 馃

@jeremydaly
Copy link
Owner

Sorry for the delay. Looking at this.

@omichowdhury
Copy link
Contributor Author

Hey @jeremydaly, had a chance to look at this?

@jeremydaly jeremydaly merged commit 9ee608f into jeremydaly:master Jul 10, 2020
@jeremydaly
Copy link
Owner

This looks great. Merged and will be in the next release. Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entities need to list all attributes
2 participants