Update TypeScript definition file to be compatible with 0.9.x #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassankhan
suggested changes
Nov 20, 2018
|
I linked it into a project and it seems to work perfectly for me 👍 Thanks again, @Wintereise! |
|
Sounds good, thank you for testing! |
hassankhan
approved these changes
Nov 20, 2018
|
You guys are awesome! 🎉 |
|
v0.9.2 live in NPM |
|
Thanks @jeremydaly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added exports to all the exported entity definitions, fixed the middleware method signature(s), and added type definitions for the new discreet error types introduced in 0.9.
I've tested it with my own production API and have not run into any difficulties. Nonetheless, I'd appreciate if @hassankhan looks this over since it largely builds atop his work.
Thank you to everyone!