Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fan-out lambda missing lastAccess attribute #6

Merged

Conversation

jmhummel
Copy link
Contributor

@jmhummel jmhummel commented May 8, 2019

The lastAccess attribute is only set on the child invocations, but not on the original parent, which leads to both lastAccessed and lastAccessedSeconds fields appearing null on warm lambdas

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 14: 0.0%
Covered Lines: 32
Relevant Lines: 32

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 8, 2019

Pull Request Test Coverage Report for Build 15

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 14: 0.0%
Covered Lines: 32
Relevant Lines: 32

💛 - Coveralls

@jmhummel
Copy link
Contributor Author

jmhummel commented May 8, 2019

Screenshot from CloudWatch:
image

@jmhummel
Copy link
Contributor Author

jmhummel commented May 9, 2019

More recent screenshot after schedule has run for a while, showing that only lambdas with count > 1 contain the lastAccessed and lastAccessedSeconds fields in their log output:
image

@jmhummel
Copy link
Contributor Author

@jeremydaly Could you review this PR when you get a chance?

@jeremydaly
Copy link
Owner

Yes, sorry for the delay. I'll look at it tonight. Thanks for submitting it.

@jeremydaly jeremydaly merged commit d6fa1ad into jeremydaly:master May 15, 2019
@jeremydaly
Copy link
Owner

I've merged this in and will add it to the next version.

@jmhummel jmhummel deleted the fix/fanout-lambda-missing-lastAccess branch May 20, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants