forked from rack/rack
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not reference HTTP_VERSION internally
HTTP_VERSION is supposed to be a client supplied header. This usage inside Rack is conflating it with SERVER_PROTOCOL, which imo is instead also conflating it with the client's HTTP version from the request line. In any of these cases, HTTP_VERSION is set when an existing Version header doesn't already exist. So it's possible to send a Version header to conflict with the expected behaviors. According to the CGI spec (https://tools.ietf.org/html/draft-robinson-www-interface-00) > Environment variables with names beginning with "HTTP_" contain header data read from the client, if the protocol used was HTTP. This is an anscillary issue with Rack, but will leave that open for discussion since this behavior already exists.
- Loading branch information
1 parent
d55193d
commit e702d31
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters