Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On app startup. Getting message > Rack::Handler is deprecated and replaced by Rackup::Handler #301

Closed
mmarvb8h opened this issue Jan 14, 2023 · 2 comments

Comments

@mmarvb8h
Copy link

mmarvb8h commented Jan 14, 2023

Built first Roda app. Normally Rails user.

Mac M1
I am using puma 6.0.2 and ruby 3.1.2
rack 3.0.3.

Not sure if this is coming from ur App class or from Puma. Immediately after deprecation warning, puma starts.

All runs... but wondering if there is an underlying issue that i need to address.

~thx Marvin Foster -> mmarvb7@gmail.com

@jeremyevans
Copy link
Owner

This is a Rack 3 issue, not a Roda issue. Not sure how you are starting your application, but you either need to use Rack 2 or make sure how you are running the server is Rack 3 compatible. You may want to review https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md. If you are using the puma command to run the server, you would have to ask the Puma team, since the issue would be in Puma, regardless of the framework you are using for the application.

@marvfinsy
Copy link

marvfinsy commented Jan 15, 2023

thx for the response.
I spent Sunday afternoon more deeply looking at this and it seems to be a puma "issue".

  1. I'm using a config.ru file and was starting app: %> bin/rackup. This shows the warning.
  2. Starting using: %> bin/puma . No warning message.
  3. Issue occurs as rackup tries to start puma and require puma.rb.
  4. The code in puma.rb does a require on rack header.rb. Rack header.rb shows deprecation warning. This explains why using puma directly does not show error. I assume puma will fix in upcoming minor release.

Again... thanks for ur response.
~Marvin...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants