Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: gem install bundler #1305

Merged

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Feb 8, 2017

This PR adds a before_install step to install a Bundler, in order to see if jruby-head can build.

Update: That did it. It now runs, see Travis build configured on my fork.

And, comes up with a test failure on jruby-head:

  1) Failure:
Supported types#test_0010_should support generic time type [/home/travis/build/olleolleolle/sequel/spec/integration/type_test.rb:83]:
Expected: "'19:49:16.047188'"
  Actual: "'19:49:16.047000'"

@jeremyevans
Copy link
Owner

This looks fine to me, but can you please rebase this into a single commit so there isn't so much code churn?

@olleolleolle
Copy link
Contributor Author

@jeremyevans There.

@janko
Copy link
Contributor

janko commented Feb 8, 2017

Awesome, I'm having the same problem in my open source project, it's great to know there is a fix!

@jeremyevans jeremyevans merged commit 4c46164 into jeremyevans:master Feb 8, 2017
@olleolleolle olleolleolle deleted the fix/jruby-head-attempt-build branch February 8, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants