Skip to content

Commit

Permalink
Merge pull request #312 from jeremyjh/module_name
Browse files Browse the repository at this point in the history
Qualify unknown function names.
  • Loading branch information
asummers committed Apr 1, 2019
2 parents d6a8e51 + e840a25 commit 09c5d63
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .dialyzer_ignore.exs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[
{":0:unknown_function Function t_is_opaque/1 does not exist."},
{":0:unknown_function Function t_to_string/1 does not exist."},
{":0:unknown_function Function :erl_types.t_is_opaque/1 does not exist."},
{":0:unknown_function Function :erl_types.t_to_string/1 does not exist."},
~r/format_(long|short).*no local return/
]
5 changes: 3 additions & 2 deletions lib/dialyxir/warnings/unknown_function.ex
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ defmodule Dialyxir.Warnings.UnknownFunction do

@impl Dialyxir.Warning
@spec format_short({String.t(), String.t(), String.t()}) :: String.t()
def format_short({_module, function, arity}) do
"Function #{function}/#{arity} does not exist."
def format_short({module, function, arity}) do
pretty_module = Erlex.pretty_print(module)
"Function #{pretty_module}.#{function}/#{arity} does not exist."
end

@impl Dialyxir.Warning
Expand Down

0 comments on commit 09c5d63

Please sign in to comment.