Failed to parse warning

[blatyo]

Using: 1.0.0-rc.3

Failed to parse warning:
[{:"(", 1}, {:atom_part, 1, 'A'}, {:atom_part, 1, 't'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'm'}, {:",", 1}, {:atom_part, 1, 'E'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'c'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'd'}, {:atom_part, 1, 'i'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'g'}, {:")", 1}, {:->, 1}, {:atom_part, 1, 'b'}, {:atom_part, 1, 'i'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'a'}, {:atom_part, 1, 'r'}, {:atom_part, 1, 'y'}, {:"(", 1}, {:")", 1}, {:atom_part, 1, 'w'}, {:atom_part, 1, 'h'}, {:atom_part, 1, 'e'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'A'}, {:atom_part, 1, 't'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'm'}, {:::, 1}, {:atom_part, 1, 'a'}, {:atom_part, 1, 't'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'm'}, {:"(", 1}, {:")", 1}, {:",", 1}, {:atom_part, 1, 'E'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'c'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'd'}, {:atom_part, 1, 'i'}, {:atom_part, 1, 'n'}, {:atom_part, 1, ...}, {:::, ...}, {...}, ...]


Legacy warning:
lib/conduit/broker/outgoing_scope.ex:73: The call erlang:atom_to_binary(binary(),'utf8') breaks the contract (Atom,Encoding) -> binary() when Atom :: atom(), Encoding :: 'latin1' | 'unicode' | 'utf8'

[asummers]

Huh interesting. I totally don't have any concept of whens yet in Erlex (underlying parsing lib) and no one's reported one of these yet. Will work on getting that added. Thanks for the report.

[asummers]

Can you paste the surrounding function head and spec, if you don't mind @blatyo

[blatyo]

The line it's referring to is here:

https://github.com/conduitframework/conduit/blob/dialyxir-issue/lib/conduit/broker/outgoing_scope.ex#L73

[blatyo]

I believe a simplified case that will generate this is (untested):

defmodule X do
  def x do
    Atom.to_string("not an atom")
  end
end

[blatyo]

The issue is that this is incorrectly typed as string instead of atom: https://github.com/conduitframework/conduit/blob/dialyxir-issue/lib/conduit/broker/publish_route.ex#L10

[asummers]

Thanks. Might not get to it for a few days, but this is on my radar. If you're feeling adventurous, PRs are certainly welcome =)

[asummers]

I have a tentative fix for it on asummers/erlex#8 but I don't have time this evening to test on your project -- can you give that a spin and let me know if it looks okay? I should get some time to run on your project tomorrow, if not.

[blatyo]

Doesn't seem to work. I ran with erlex overriden to your branch:

https://github.com/conduitframework/conduit/blob/dialyxir-issue/mix.exs#L61

Failed to parse warning:
[{:"(", 1}, {:atom_part, 1, 'A'}, {:atom_part, 1, 't'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'm'}, {:",", 1}, {:atom_part, 1, 'E'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'c'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'd'}, {:atom_part, 1, 'i'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'g'}, {:")", 1}, {:->, 1}, {:atom_part, 1, 'b'}, {:atom_part, 1, 'i'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'a'}, {:atom_part, 1, 'r'}, {:atom_part, 1, 'y'}, {:"(", 1}, {:")", 1}, {:atom_part, 1, 'w'}, {:atom_part, 1, 'h'}, {:atom_part, 1, 'e'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'A'}, {:atom_part, 1, 't'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'm'}, {:::, 1}, {:atom_part, 1, 'a'}, {:atom_part, 1, 't'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'm'}, {:"(", 1}, {:")", 1}, {:",", 1}, {:atom_part, 1, 'E'}, {:atom_part, 1, 'n'}, {:atom_part, 1, 'c'}, {:atom_part, 1, 'o'}, {:atom_part, 1, 'd'}, {:atom_part, 1, 'i'}, {:atom_part, 1, 'n'}, {:atom_part, 1, ...}, {:::, ...}, {...}, ...]


Legacy warning:
lib/conduit/broker/outgoing_scope.ex:73: The call erlang:atom_to_binary(binary(),'utf8') breaks the contract (Atom,Encoding) -> binary() when Atom :: atom(), Encoding :: 'latin1' | 'unicode' | 'utf8'

[asummers]

Hmm yeah that should be working. I'll see if I can figure out why it's still upset.

[asummers]

@blatyo Interesting. Seems to be working, but overriding it in that manner wasn't seeming to take it? Unsure why. I had to pull down a copy of Dialyxir and override it in there. Will merge the Erlex PR and make the associated bump here.