Added when clauses in pretty printed contracts. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asummers
force-pushed
the
add-when-clauses
branch
from
80d75f9
to
e5bf43e
Compare
blatyo
reviewed
Aug 23, 2018
| pretty_printed = Erlex.pretty_print(input) | ||
|
|
||
| expected_output = | ||
| "(:Atom, :Encoding) :: binary() when Atom: atom(), Encoding: :latin1 | :utf8" |
There was a problem hiding this comment.
Atom and Encoding are variables, not atoms. I think the output should be:
"(atom, encoding) :: binary() when atom :: atom(), encoding :: :latin1 | :utf8"
There was a problem hiding this comment.
That's a deeper issue this exposed that is slightly out of scope of this fix. I need to figure out how to detect Erlang terms as opposed to Elixir ones and handle them specially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to let this sit for a second to coordinate with reporting user to verify fix. This also fixes up some minor issues from #4 found when implementing.
Resolves #2