-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for PHP 7.2 in 3.x branch #204
Comments
I don't see why we can't backport 7.2 support. @nyamsprod Thoughts? |
I could do it but v4 code is really old 👎 I'll give it a try .. I need to look into it we will label this as a security patch :) also it means upping to v4 for domain parser too . |
Upping to v4? Adding that conditional will cause a BC break in php-domain-parser? |
Looks like |
Not further needed since thephpleague/uri-src#41 was solved. |
Since
INTL_IDNA_VARIANT_2003
variant has been deprecated in PHP 7.2, using Payum which uses League/Uri which uses this library is impossible on that version (I've listed the details here: Sylius/Sylius#8771 (comment)).The thing I'd like to introduce in
3.0.1
release is to changeidn_to_ascii
andidn_to_utf8
function calls with something like:Either:
@idn_to_ascii($part)
Or:
Or:
All I need to fix this is a branch based on
3.0.0
version tag available, the choice of the suitable solution, then merging a PR and releasing3.0.1
. It really would help anyone using Payum with the most recent PHP version and I'll be grateful for help :)The text was updated successfully, but these errors were encountered: