New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sylius compatible with PHP 7.2 #8771

Merged
merged 2 commits into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@stefandoorn
Contributor

stefandoorn commented Oct 4, 2017

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Run test suite already against PHP 7.2 to pro-actively make adjustments before PHP 7.2 is released (if possible). Not sure if this should be against 1.0 or master though ;-)

@stefandoorn

This comment has been minimized.

Show comment
Hide comment
@stefandoorn

stefandoorn Oct 4, 2017

Contributor

First issue spotted: friendsofphp/php-cs-fixer needs to be at 2.6.1 at least to support PHP 7.2.

Contributor

stefandoorn commented Oct 4, 2017

First issue spotted: friendsofphp/php-cs-fixer needs to be at 2.6.1 at least to support PHP 7.2.

@stefandoorn stefandoorn changed the title from Test suite against PHP 7.2 to [WIP] Test suite against PHP 7.2 Oct 4, 2017

@stefandoorn

This comment has been minimized.

Show comment
Hide comment
@stefandoorn

stefandoorn Oct 4, 2017

Contributor

I'm not sure how to figure out what the Behat errors are. Output seems scarce.

Contributor

stefandoorn commented Oct 4, 2017

I'm not sure how to figure out what the Behat errors are. Output seems scarce.

@gabiudrescu

This comment has been minimized.

Show comment
Hide comment
@gabiudrescu

gabiudrescu Oct 6, 2017

Contributor

@stefandoorn if you check this etc/travis/run-suite after_failure "${SYLIUS_SUITE}" the build log, you can reach this:

http://termbin.com/uw75

which is pretty verbose.

Contributor

gabiudrescu commented Oct 6, 2017

@stefandoorn if you check this etc/travis/run-suite after_failure "${SYLIUS_SUITE}" the build log, you can reach this:

http://termbin.com/uw75

which is pretty verbose.

@stefandoorn

This comment has been minimized.

Show comment
Hide comment
@stefandoorn

stefandoorn Oct 7, 2017

Contributor

Ok..

idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /home/travis/build/Sylius/Sylius/vendor/league/uri/src/Components/HostnameTrait.php line 68

league/uri is required by Payum at ~4.0. Not sure about it, but issue might be fixed in league/uri 5.x. Doesn't seem Payum already supports this, so this might be a hard path to get fixed.

Contributor

stefandoorn commented Oct 7, 2017

Ok..

idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /home/travis/build/Sylius/Sylius/vendor/league/uri/src/Components/HostnameTrait.php line 68

league/uri is required by Payum at ~4.0. Not sure about it, but issue might be fixed in league/uri 5.x. Doesn't seem Payum already supports this, so this might be a hard path to get fixed.

@stefandoorn

This comment has been minimized.

Show comment
Hide comment
@stefandoorn

stefandoorn Oct 7, 2017

Contributor

Anyone also knows the URL on which the imgur uploaded screenshots can be found?

Contributor

stefandoorn commented Oct 7, 2017

Anyone also knows the URL on which the imgur uploaded screenshots can be found?

@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Oct 9, 2017

Member

@stefandoorn looks like our imgur API key is not valid so uploading screenshots has stopped working.

Member

pamil commented Oct 9, 2017

@stefandoorn looks like our imgur API key is not valid so uploading screenshots has stopped working.

Show outdated Hide outdated .travis.yml Outdated
Show outdated Hide outdated composer.json Outdated
@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Oct 10, 2017

Member

Not sure if this should be against 1.0 or master though ;-)

IMO it should go for 1.0 branch as 1.0 requires PHP ^7.1, so PHP 7.2 should also be supported there. (rebase needed though then)

Member

pamil commented Oct 10, 2017

Not sure if this should be against 1.0 or master though ;-)

IMO it should go for 1.0 branch as 1.0 requires PHP ^7.1, so PHP 7.2 should also be supported there. (rebase needed though then)

@pamil pamil changed the base branch from master to 1.0 Oct 10, 2017

@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Oct 10, 2017

Member

As for that Payum-related errors:

  • Payum itself requires PHP 5.5+
  • Payum requires thephpleague/uri v4:
    • thephpleague/uri v4 requires PHP 5.5+
    • thephpleague/uri v4 uses the deprecated function call
    • thephpleague/uri v4 requires jeremykendall/php-domain-parser v3:
      • jeremykendall/php-domain-parser v3 uses the deprecated function call
  • If Payum requires thephpleague/uri v5:
    • thephpleague/uri v5 requires PHP 7.0+
    • thephpleague/uri v5 requires jeremykendall/php-domain-parser v4.0.3-alpha:
      • jeremykendall/php-domain-parser v4.0.3-alpha does not use the deprecated function call

Conclusion:

Member

pamil commented Oct 10, 2017

As for that Payum-related errors:

  • Payum itself requires PHP 5.5+
  • Payum requires thephpleague/uri v4:
    • thephpleague/uri v4 requires PHP 5.5+
    • thephpleague/uri v4 uses the deprecated function call
    • thephpleague/uri v4 requires jeremykendall/php-domain-parser v3:
      • jeremykendall/php-domain-parser v3 uses the deprecated function call
  • If Payum requires thephpleague/uri v5:
    • thephpleague/uri v5 requires PHP 7.0+
    • thephpleague/uri v5 requires jeremykendall/php-domain-parser v4.0.3-alpha:
      • jeremykendall/php-domain-parser v4.0.3-alpha does not use the deprecated function call

Conclusion:

@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Oct 10, 2017

Member

jeremykendall/php-domain-parser#204 and thephpleague/uri#105 have been opened, let's wait for the replies.

Member

pamil commented Oct 10, 2017

jeremykendall/php-domain-parser#204 and thephpleague/uri#105 have been opened, let's wait for the replies.

@pamil pamil added this to the 1.0 milestone Oct 17, 2017

@stefandoorn stefandoorn changed the title from [WIP] Test suite against PHP 7.2 to Make Sylius compatible with PHP 7.2 Oct 17, 2017

@stefandoorn

This comment has been minimized.

Show comment
Hide comment
@stefandoorn

stefandoorn Oct 17, 2017

Contributor

@pamil Ready to review. Had to explicitly require the updated dependencies to get the proper versions installed.

Build on PHP 7.3 fails due to PHP-CS-Fixer not allowing 7.3. I'm not sure we should disallow installation on PHP 7.3 due to this.

Contributor

stefandoorn commented Oct 17, 2017

@pamil Ready to review. Had to explicitly require the updated dependencies to get the proper versions installed.

Build on PHP 7.3 fails due to PHP-CS-Fixer not allowing 7.3. I'm not sure we should disallow installation on PHP 7.3 due to this.

@pamil

Awesome! Can you add packages build for PHP 7.2? It's like the one for PHP 7.1 but with docs removed from $SYLIUS_SUITE 🎉

@pamil

pamil approved these changes Oct 17, 2017

@pamil pamil merged commit 153e380 into Sylius:1.0 Oct 17, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Oct 17, 2017

Member

Thanks Stefan, great job! 🥇

Member

pamil commented Oct 17, 2017

Thanks Stefan, great job! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment