Make Sylius compatible with PHP 7.2

[stefandoorn]

Q	A
Branch?	1.0
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

Run test suite already against PHP 7.2 to pro-actively make adjustments before PHP 7.2 is released (if possible). Not sure if this should be against 1.0 or master though ;-)

[stefandoorn]

First issue spotted: friendsofphp/php-cs-fixer needs to be at 2.6.1 at least to support PHP 7.2.

[stefandoorn]

I'm not sure how to figure out what the Behat errors are. Output seems scarce.

[gabiudrescu]

@stefandoorn if you check this etc/travis/run-suite after_failure "${SYLIUS_SUITE}" the build log, you can reach this:

http://termbin.com/uw75

which is pretty verbose.

[stefandoorn]

Ok..

idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /home/travis/build/Sylius/Sylius/vendor/league/uri/src/Components/HostnameTrait.php line 68

league/uri is required by Payum at ~4.0. Not sure about it, but issue might be fixed in league/uri 5.x. Doesn't seem Payum already supports this, so this might be a hard path to get fixed.

[stefandoorn]

Anyone also knows the URL on which the imgur uploaded screenshots can be found?

[pamil]

@stefandoorn looks like our imgur API key is not valid so uploading screenshots has stopped working.

[pamil]

I'd skip the nightly PHP version for now as there's still some time until PHP 7.3 gets released & builds will take more time to finish.

[pamil]

Instead, running packages build on PHP 7.2 is a must :)

[stefandoorn]

Mainly added nightly for now as it might discover some issues now already that we can tackle directly. Will take it out before finalising PR.

[pamil]

Same change applies for every Sylius package using phpspec (packages build on PHP 7.2 would fail without this one).

[stefandoorn]

Alright. Need to see if this change is required at all before finalising PR.

[pamil]

Not sure if this should be against 1.0 or master though ;-)

IMO it should go for 1.0 branch as 1.0 requires PHP ^7.1, so PHP 7.2 should also be supported there. (rebase needed though then)

[pamil]

As for that Payum-related errors:

• Payum itself requires PHP 5.5+
• Payum requires thephpleague/uri v4:
  • thephpleague/uri v4 requires PHP 5.5+
  • thephpleague/uri v4 uses the deprecated function call
  • thephpleague/uri v4 requires jeremykendall/php-domain-parser v3:
    • jeremykendall/php-domain-parser v3 uses the deprecated function call
• If Payum requires thephpleague/uri v5:
  • thephpleague/uri v5 requires PHP 7.0+
  • thephpleague/uri v5 requires jeremykendall/php-domain-parser v4.0.3-alpha:
    • jeremykendall/php-domain-parser v4.0.3-alpha does not use the deprecated function call

Conclusion:

• Getting Payum to use the newer thephpleague/uri would require to drop PHP 5.5 / 5.6 support for them (and probably a lot of work)
• We can try to send bugfixes to thephpleague/uri v4 and jeremykendall/php-domain-parser v3 to use that not deprecated variant in idn_to_* functions (like done here - https://github.com/jeremykendall/php-domain-parser/blob/4.0.3-alpha/src/Pdp/Parser.php#L318-L322)

[pamil]

jeremykendall/php-domain-parser#204 and thephpleague/uri-src#41 have been opened, let's wait for the replies.

[stefandoorn]

@pamil Ready to review. Had to explicitly require the updated dependencies to get the proper versions installed.

Build on PHP 7.3 fails due to PHP-CS-Fixer not allowing 7.3. I'm not sure we should disallow installation on PHP 7.3 due to this.

[pamil]

Awesome! Can you add packages build for PHP 7.2? It's like the one for PHP 7.1 but with docs removed from $SYLIUS_SUITE 🎉

[pamil]

Thanks Stefan, great job! 🥇