Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel Consolidate Namespaces Shift #370

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Laravel Consolidate Namespaces Shift #370

merged 1 commit into from
Sep 29, 2020

Conversation

jeremykenedy
Copy link
Owner

This pull request includes the changes for consolidating custom namespaces. Commit any additional changes to the shift-34005 branch.

Before merging, you need to:

  • Checkout the shift-34005 branch
  • Run composer dump-autoload
  • Review all pull request comments for additional changes
  • Thoroughly test your application

If there were changes you feel could have been automated, please send your feedback to shift@laravelshift.com or via Twitter.

The Laravel framework adopts the PSR-2 coding style with some additions.
Laravel apps *should* adopt this coding style as well.

However, Shift allows you to customize the adopted coding style by
adding your own [PHP CS Fixer][1] `.php_cs` config to your project.

You may use [Shift's .php_cs][2] file as a base.

[1]: https://github.com/FriendsOfPHP/PHP-CS-Fixer
[2]: https://gist.github.com/laravel-shift/cab527923ed2a109dda047b97d53c200
@jeremykenedy
Copy link
Owner Author

ℹ️ The following namespaces were not consolidated since their paths were outside of the Laravel app/ folder. If you would like to consolidate any of these namespaces, you may move them within app/ and request a rerun of this Shift.

  • Database\Factories
  • Database\Seeders

@jeremykenedy jeremykenedy merged commit 7713835 into master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants