Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating wrong url #21

Closed
azorpax opened this issue Sep 22, 2018 · 7 comments
Closed

Generating wrong url #21

azorpax opened this issue Sep 22, 2018 · 7 comments

Comments

@azorpax
Copy link
Contributor

azorpax commented Sep 22, 2018

laravel-logger/src/resources/views/logger/partials/activity-table.blade.php

Line 137 in a973d90

<a href="@if($activity->route != '/')/@endif{{$activity->route}}">

Hi, I am not sure if I'm the only one who encountered this bug or not bug?
The URL is generating like this:
mywebsite.com/http://mywebsite.com/xxxxx/xxx
@azorpax
Copy link
Contributor Author

azorpax commented Sep 24, 2018

w/o reply?

@jeremykenedy
Copy link
Owner

https://github.com/jeremykenedy/laravel-logger/blob/master/README.md#opening-an-issue

@azorpax
Copy link
Contributor Author

azorpax commented Sep 24, 2018

Done starring the repo. Now will you consider my two issues?

@jeremykenedy jeremykenedy reopened this Sep 24, 2018
@jeremykenedy
Copy link
Owner

I can replicate this, looking into...

@azorpax
Copy link
Contributor Author

azorpax commented Sep 27, 2018

Are you still working into this?

@jeremykenedy
Copy link
Owner

I haven't had time and most likely will not until this weekend. Thank you for letting me know and for all the contributions lately.

jeremykenedy added a commit that referenced this issue Oct 2, 2018
@jeremykenedy
fix reported GH error #21
7e54957
jeremykenedy added a commit that referenced this issue Oct 2, 2018
@jeremykenedy
Merge pull request #33 from jeremykenedy/link-fix
4e1805d 
fix reported GH error #21
@jeremykenedy
Copy link
Owner

This has been fixed in the PR 7e54957

Thank you again! :)

@amirhosseinporsami amirhosseinporsami mentioned this issue Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremykenedy @azorpax