Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaravelLoggerController.php on line 12: "App\Http\Controllers\Controller" hardcoded #3

Closed
peyobr opened this issue Mar 21, 2018 · 5 comments

Comments

@peyobr
Copy link
Contributor

peyobr commented Mar 21, 2018

Just installed:

PHP Fatal error: Class 'App\Http\Controllers\Controller' not found in /vendor/jeremykenedy/laravel-logger/src/app/Http/Controllers/LaravelLoggerController.php on line 12

My application have app:name set.

Is it possible to override

Thank you.

@jeremykenedy
Copy link
Owner

jeremykenedy commented Mar 21, 2018

I cannot duplicate. Make sure you followed all the installation steps.

@peyobr
Copy link
Contributor Author

peyobr commented Mar 21, 2018

Please read carefully the issue subject: your controller extend default App\Http\Controllers\Controller.

This make your package unusable if application namespace has been changed using "php artisan app:name" (i.e. "MyApp")

@jeremykenedy
Copy link
Owner

jeremykenedy commented Mar 21, 2018

Then it looks like you will need to make changes to support “your” custom application.
What solutions can you offer in a PR?

@peyobr
Copy link
Contributor Author

peyobr commented Mar 21, 2018

Simply extending: Illuminate\Routing\Controller

I'll submit PR asap

thak you

@jeremykenedy
Copy link
Owner

Awesome, thank you

jeremykenedy pushed a commit that referenced this issue Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants