Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation says 'runtime artifacts are not bundled in distribution' ? #5392

Closed
mehradn7 opened this issue Jan 27, 2023 · 1 comment · Fixed by #5399
Closed

Documentation says 'runtime artifacts are not bundled in distribution' ? #5392

mehradn7 opened this issue Jan 27, 2023 · 1 comment · Fixed by #5399
Assignees
Labels

Comments

@mehradn7
Copy link

Hello,

The documentation of the Maven plugin (https://jeremylong.github.io/DependencyCheck/dependency-check-maven/index.html) says (Example 4):

Create the dependency-check-report.html and skip artifacts not bundled in distribution (Provided and Runtime scope).

to demonstrate the <skipRuntimeScope>true</skipRuntimeScope> configuration option.

But is it true that a Maven dependency declared with scope "runtime" will not be bundled in distribution ? E.g. as far as I know, the spring-boot:repackage plugin goal bundles a JAR with runtime artifacts included.

In such case, from a security prospective, wouldn't it be better not to suggest excluding runtime scope artifacts from the Dependency Check scan ?

Thank you for your answer.

Regards,

@mehradn7 mehradn7 changed the title Doc says runtime artifacts are not bundled in distribution ? Documentation says 'runtime artifacts are not bundled in distribution' ? Jan 27, 2023
@aikebah
Copy link
Collaborator

aikebah commented Jan 27, 2023

Runtime scope is indeed usualky bundled... think we should update the docs

@jeremylong jeremylong self-assigned this Jan 30, 2023
jeremylong added a commit that referenced this issue Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants