Adds configurable batch insert for References and Vulnerabilities #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 17, 2017 10:36
Applies batch inserts for reference and vulnerability tables, solves the slow one-by-one insert process, for Vulnerabilities with several references/vulnerabilities associated.
Applies batch inserts for reference and vulnerability tables, solves slow one-by-one insert process, for Vulnerabilities with several references/vulnerabilities associated. Feature is configurable through properties: database.batchinsert.enabled and database.batchinsert.maxsize.
cve.startyear value is 2002.
|
Can one of the admins verify this patch? |
Remove unused variable.
|
Thanks! It will likely be next weekend before I can take a look at this update. |
|
Thanks for the PR - I've done some testing on mysql and the earlier issues identified with batching look like they have been resolved via other changes to the tool. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Makes use of batch capabilities of PreparedStatement. Executes updates every n rows (configurable), slowing down time for vulnerabilities updates by a near 10x factor on external databases (Postgresql for instance).
Tested on H2 (default), and Postgresql.
Description of Change
Applies batch inserts for reference and vulnerability tables, solves
slow one-by-one insert process, for Vulnerabilities with several
references/vulnerabilities associated.
Feature is configurable through properties:
database.batchinsert.enabledand
database.batchinsert.maxsize.Have test cases been added to cover the new functionality?
no
Tests available already cover the process. All tests where executed before pushing code to forked repository