Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken CVE2.0 url links in property and markdown files #1172

Merged
merged 2 commits into from
Apr 1, 2018
Merged

Conversation

0xRCE
Copy link

@0xRCE 0xRCE commented Mar 30, 2018

Fixes Issue #1171

Description of Change

Changed the urls for CVE 2.0 original and modified entries to the new addres

Have test cases been added to cover the new functionality?

no, existing are already testing this functionalitiy

@jeremylong
Copy link
Owner

Can one of the admins verify this patch?

@baffles
Copy link

baffles commented Mar 30, 2018

cveUrl20Base in cli/src/site/markdown/arguments.md is incorrect

Copy link

@acooley acooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this ASAP. This is a popular bit of opensource software and builds are breaking because of this.

@zachofalltrades
Copy link

It will be a whole lot easier for me to fix all of my broken builds by bumping up the version of this plugin rather than adding the additional configuration for the various feed URLs. But I do appreciate the work you are doing with this!

@@ -27,7 +27,7 @@ Advanced Options
Short | Argument Name        | Parameter | Description | Default Value
-------|------------------------|-----------------|----------------------------------------------------------------------------------|-------------------
| \-\-cveUrl12Modified | \<url\> | URL for the modified CVE 1.2 | https://nvd.nist.gov/download/nvdcve-Modified.xml.gz
| \-\-cveUrl20Modified | \<url\> | URL for the modified CVE 2.0 | https://nvd.nist.gov/feeds/xml/cve/nvdcve-2.0-Modified.xml.gz
| \-\-cveUrl20Modified | \<url\> | URL for the modified CVE 2.0 | https://nvd.nist.gov/feeds/xml/cve/2.0/nvdcve-2.0-Modified.xml.gz
| \-\-cveUrl12Base | \<url\> | Base URL for each year's CVE 1.2, the %d will be replaced with the year | https://nvd.nist.gov/download/nvdcve-%d.xml.gz
| \-\-cveUrl20Base | \<url\> | Base URL for each year's CVE 2.0, the %d will be replaced with the year | https://nvd.nist.gov/feeds/xml/cve/nvdcve-2.0-%d.xml.gz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be changed as well.

@AndiDog
Copy link

AndiDog commented Mar 30, 2018

Didn't the 1.2 URLs also change?

@jeremylong jeremylong merged commit 88c5cc8 into jeremylong:master Apr 1, 2018
@jeremylong
Copy link
Owner

Sorry everyone - of course something happens like this when I am traveling for vacation... I'll get this pushed shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants