Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project name required #1871

Closed
wants to merge 1 commit into from
Closed

Conversation

tobmaster
Copy link

Fixes Issue

Description of Change

Changed the project name parameter to required, as it is required by the cli tool

Have test cases been added to cover the new functionality?

no

@jeremylong
Copy link
Owner

The project name is not required in the 5.0.0-m1 or 5.0.0-m2 releases. The documentation that is published is for the m2 release. You can see here that the project argument is no longer required:

public String getProjectName() {
String name = line.getOptionValue(ARGUMENT.PROJECT);
if (name == null) {
name = "";
}
return name;
}

We hope to be code complete with the 5.0.0 branch soon. Sorry for the confusion.

@jeremylong jeremylong closed this Apr 25, 2019
@lock lock bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants