Fix for Dependencies with classifier and SNAPSHOT #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue jeremylong#3786 Dependencies with a classifier and SNAPSHOT version cannot be resolved bug
|
ping @aikebah as you may want to review my (minor) change on the method |
|
For an explanation of |
|
LGTM |
|
Thanks for the PR @fmarot overlooked this scenario, which has bitten me in other cases in the past. When I read your ping and the summary it was immediately obvious to me what the change was about |
aikebah
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3786
Dependencies with a classifier and SNAPSHOT version cannot be resolved bug
Fixes Issue #3786
Description of Change
Since recent changes to workaround MSHARED-998 the use of the class ArtifactResult appeared in the code. While this class looks like ArtifactCoordinate, we have to take care of the
getVersion()method because for SNAPSHOT versions it provides the timestamped result, not the 'real' version.So I only changed the
getVersion()bygetBaseVersion()call for class ArtifactResult.I have tested the change manually with a fake project and it solves the DependencyNotFoundException as expected.
Have test cases been added to cover the new functionality?
no, not yet, sorry...