Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some more flaws with gitlab report format #6193

Merged
merged 4 commits into from Dec 2, 2023
Merged

fix: some more flaws with gitlab report format #6193

merged 4 commits into from Dec 2, 2023

Conversation

weyhmueller
Copy link
Contributor

Fixes Issue #6187

Description of Change

This changes the format of some fields in the gitlab report template:

  • Adapt the logic to find the severity of a vulnerability so that it behaves like other reports.
  • Handle references without a name
  • Handle dependencies consisting of multiple files where only the main file has a name and a description.

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg bot added the core changes to core label Dec 1, 2023
@weyhmueller weyhmueller mentioned this pull request Dec 1, 2023
Closed
@jeremylong jeremylong added this to the 9.0.3 milestone Dec 2, 2023
@jeremylong jeremylong merged commit 038e353 into jeremylong:main Dec 2, 2023
6 checks passed
@jeremylong jeremylong mentioned this pull request Dec 4, 2023
Closed
@weyhmueller weyhmueller deleted the fix/more-gitlab-report-fixes branch December 13, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylong jeremylong jeremylong approved these changes

Assignees
No one assigned
Labels
core changes to core
Projects
None yet
Milestone
9.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weyhmueller @jeremylong