Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework and polish docker image #140

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Rework and polish docker image #140

merged 7 commits into from
Feb 28, 2024

Conversation

EugenMayer
Copy link
Contributor

@EugenMayer EugenMayer commented Feb 28, 2024 •
edited
Loading

Rework different aspects of the docker image

  1. Add flags as ENV to enable debug, set maxRetries, or max records per page ( more https://github.com/EugenMayer/helm-charts/blob/main/charts/vulnz-nvd-mirror/values.yaml#L44 )
  2. Use jdk17 (not 11)
  3. Fix cron setup and logging
  4. Fix supervisor setup using wrong configuration (supervisorctl was unusable without flags)
  5. Polish supervisor configuration
  6. ensure proper group memberships
  7. Better startup logging

Changes should be squashed on merge

@EugenMayer EugenMayer mentioned this pull request Feb 28, 2024
Closed
jeremylong
jeremylong requested changes Feb 28, 2024
View reviewed changes
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great. One minor update requested to prevent a future issue.

vulnz/src/docker/scripts/mirror.sh Outdated Show resolved Hide resolved
@EugenMayer @jeremylong
Update vulnz/src/docker/scripts/mirror.sh
77eb657 
Co-authored-by: Jeremy Long <jeremy.long@gmail.com>
jeremylong
jeremylong approved these changes Feb 28, 2024
View reviewed changes
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit 634ceba into jeremylong:main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylong jeremylong jeremylong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EugenMayer @jeremylong