Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move conformal maps to library #48

Merged
merged 100 commits into from
Aug 11, 2022
Merged

Move conformal maps to library #48

merged 100 commits into from
Aug 11, 2022

Conversation

AdelekeBankole
Copy link
Collaborator

No description provided.

jedbrown
jedbrown reviewed Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to target this PR to main rather than Jeremy's transplanted_quadrature branch. That'll likely require some squashing of commits.

src/Basis/Constructors.jl Outdated Show resolved Hide resolved
src/Basis/Constructors.jl Outdated Show resolved Hide resolved
@jedbrown jedbrown changed the base branch from transplanted_quadrature to main March 14, 2022 03:41
jedbrown
jedbrown reviewed Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reset the PR target. There are 7 commits that need to be squashed to avoid false starts. (Please ask if you need help with doing this or understanding why.) There's a failing style check (sort of weird line length reasons). When you push updates, the continuous integration will re-run and you'll want to confirm that it succeeds.

src/Basis/Constructors.jl Show resolved Hide resolved
examples/ex010_advection.jl Outdated Show resolved Hide resolved
examples/ex010_advection.jl Outdated Show resolved Hide resolved
examples/ex011_advection_mapped.jl Outdated Show resolved Hide resolved
examples/ex010_advection.jl Outdated Show resolved Hide resolved
AdelekeBankole and others added 13 commits March 13, 2022 23:01
@AdelekeBankole @jedbrown
Update examples/ex010_advection.jl
3c6a008 
Co-authored-by: Jed Brown <jed@jedbrown.org>
@AdelekeBankole @jedbrown
Update examples/ex010_advection.jl
367ab3e 
Co-authored-by: Jed Brown <jed@jedbrown.org>
@AdelekeBankole @jedbrown
Update src/Basis/Constructors.jl
480a345 
Co-authored-by: Jed Brown <jed@jedbrown.org>
@AdelekeBankole @jedbrown
Update examples/ex010_advection.jl
b362349 
Co-authored-by: Jed Brown <jed@jedbrown.org>
@AdelekeBankole
delete ex011_advection_mapped.jl
efef768
@AdelekeBankole
Merge branch 'transplanted_quadrature' of https://github.com/AdelekeB…
538de75 
…ankole/LFAToolkit.jl into transplanted_quadrature
@AdelekeBankole @jedbrown
Update examples/ex010_advection.jl
6f7223d 
Co-authored-by: Jed Brown <jed@jedbrown.org>
@AdelekeBankole @jedbrown
Update examples/ex010_advection.jl
1c0437f 
Co-authored-by: Jed Brown <jed@jedbrown.org>
@AdelekeBankole @jedbrown
Update src/Basis/Constructors.jl
b579f9e 
Co-authored-by: Jed Brown <jed@jedbrown.org>
@AdelekeBankole @jedbrown
Update examples/ex010_advection.jl
267baff 
Co-authored-by: Jed Brown <jed@jedbrown.org>
@AdelekeBankole
Fix g_prime syntax
5d50be9
@AdelekeBankole
Merge branch 'transplanted_quadrature' of https://github.com/AdelekeB…
4fbcfa2 
…ankole/LFAToolkit.jl into transplanted_quadrature
@AdelekeBankole
advection problem
fbb0d91
jeremylt
jeremylt reviewed Apr 6, 2022
View reviewed changes
src/Basis/Constructors.jl Outdated Show resolved Hide resolved
jeremylt
jeremylt reviewed Apr 6, 2022
View reviewed changes
src/Basis/Constructors.jl Outdated Show resolved Hide resolved
jeremylt
jeremylt reviewed Apr 6, 2022
View reviewed changes
docs/src/private/basis.md Outdated Show resolved Hide resolved
jeremylt
jeremylt reviewed Apr 6, 2022
View reviewed changes
src/Basis/Constructors.jl Outdated Show resolved Hide resolved
jedbrown
jedbrown approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

jeremylt
jeremylt requested changes Aug 11, 2022
View reviewed changes
Copy link
Owner

@jeremylt jeremylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of small fixes

test/runtests.jl Outdated Show resolved Hide resolved
examples/jupyter/demo010_advection.ipynb Outdated Show resolved Hide resolved
examples/jupyter/demo010_advection.ipynb Outdated Show resolved Hide resolved
AdelekeBankole and others added 3 commits August 11, 2022 08:53
@AdelekeBankole @jeremylt
Update test/runtests.jl
d03a3d7 
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
@AdelekeBankole @jeremylt
Update examples/jupyter/demo010_advection.ipynb
c44bd85 
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
@AdelekeBankole @jeremylt
Update examples/jupyter/demo010_advection.ipynb
330f43e 
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
@jeremylt jeremylt merged commit 2a473dd into jeremylt:main Aug 11, 2022
@jedbrown jedbrown mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedbrown jedbrown jedbrown approved these changes

@jeremylt jeremylt jeremylt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdelekeBankole @jeremylt @jedbrown