Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the idea and I often do this in my apps, so I took this gem and made some changes to fit my needs, let me know if you're interested in merge them. Here is a recap of what I did
heartbeat
endpoint (status
is too common as word). I like to simply addgem 'new_relic_ping'
in my Gemfile and have everything working out of the box./heartbeat
and/heartbeat/health
available (removed theping
suffix).newrelic_ignore
call in theHealthController
, heartbeat checks should not be reported as newrelic transactions otherwise they improve your apdex with no reason to do that. Obviously this is conditional and executed only ifnewrelic_ignore
is available in controller.I should add some test for the newly added features, but I'm not familiar with minitest I always used rspec.
Let me know what do you think of this.