Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Google Charts #38

Open
tianhuil opened this issue Jul 7, 2023 · 1 comment
Open

Don't use Google Charts #38

tianhuil opened this issue Jul 7, 2023 · 1 comment

Comments

@tianhuil
Copy link

tianhuil commented Jul 7, 2023

Hi,

I love that you are building node-2fa. Could we please remove the qr code using Google Charts? That has your entire secret, and you don't want to publish to Google. Instead, you can use QR as a data URL and only display it to the user: https://github.com/speakeasyjs/speakeasy#displaying-a-qr-code.

@satyavh
Copy link

satyavh commented Jan 9, 2024

The implementation of Google charts in this package is deprecated, shouldn't be used anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants