Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salty wet nodes do not interact with moisture? #92

Open
jeremyshannon opened this issue Feb 25, 2022 · 4 comments
Open

Salty wet nodes do not interact with moisture? #92

jeremyshannon opened this issue Feb 25, 2022 · 4 comments
Labels
bug Something isn't working confirmation_needed question Further information is requested

Comments

@jeremyshannon
Copy link
Owner

jeremyshannon commented Feb 25, 2022

Salty wet nodes are created on mapgen, but a report suggested they do not interact correctly with moisture flowing through soil?

Possible improvement; Evaporating salt water should leave salty dry nodes behind, and fresh water should become salty when moving through salty nodes, and remove the salt when they move into a non-salty neighbor.

@jeremyshannon jeremyshannon added the bug Something isn't working label Feb 25, 2022
@DokimiCU
Copy link

I was unaware it had salty dry (and can't find any?? only salty wet). I never added salty dry as... well.. it was already complicated. But they do make sense being there, and behaving as described.

@jeremyshannon
Copy link
Owner Author

Looks like you're right, there are no dry nodes. This particular issue was reported to me on IRC chat, and I later copied it down here; I may have misinterpreted what the reporter meant.

@jeremyshannon jeremyshannon changed the title Salty dry nodes do not interact with moisture Salty wet nodes do not interact with moisture? Mar 28, 2022
@jeremyshannon jeremyshannon added confirmation_needed question Further information is requested labels Mar 28, 2022
@Izzyb1234
Copy link

Izzyb1234 commented Sep 7, 2022

Instead of adding a salty dry nodes, can we use a flag to indicate a node is salty? Then we'd only need wet/dry nodes and a salty flag? Can you change the image used based on a flag?

@jeremyshannon
Copy link
Owner Author

I don't think it's possible to change image based on a property. It would need to be separate nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmation_needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants