Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension mistakes second parameter type as another parameter #22

Closed
jeremyvii opened this issue Jan 17, 2019 · 2 comments
Closed

Extension mistakes second parameter type as another parameter #22

jeremyvii opened this issue Jan 17, 2019 · 2 comments

Comments

@jeremyvii
Copy link
Owner

Describe the bug
Extension mistakes second parameter type as another parameter when language is set to TypeScript

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to run VS DocBlockr on TypeScript function with two type defined parameters
  2. See three parameter tags have been generated

Expected behavior

/**
 * [foo description]
 *
 * @param   {number}  bar     [bar description]
 * @param   {string}  thing   [thing description]
 *
 * @return  {void}            [return description]
 */
function foo(bar: number, thing: string): void {

}

Result

/**
 * [foo description]
 *
 * @param   {number}  bar     [bar description]
 * @param   {[type]}  thing:  [thing: description]
 * @param   {[type]}  string  [string description]
 *
 * @return  {void}            [return description]
 */
function foo(bar: number, thing: string): void {

}

Enviroment (please complete the following information):

  • Version: 1.30.2
  • Commit: 61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8
  • Date: 2019-01-07T22:49:48.319Z
  • Electron: 2.0.12
  • Chrome: 61.0.3163.100
  • Node.js: 8.9.3
  • V8: 6.1.534.41
  • OS: Linux x64 4.15.0-43-generic
@ShaunSpringer
Copy link

Also having this issue recently (dont know it if broke on a recent version or not)

@jeremyvii jeremyvii mentioned this issue Jan 23, 2019
jeremyvii added a commit that referenced this issue Jan 23, 2019
@jeremyvii
Copy link
Owner Author

This should fixed with the release of 0.4.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants