We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently line 224:
(accept.match(/(^|,\s*)([a-z]+)/g) || []).forEach(function(locale) {
https://github.com/jeresig/i18n-node-2/blob/master/i18n.js#L224
This only grabs the language tag, not the region tag, so it doesn't differentiate between e.g. simplified Chinese (zh-CN) and traditional (zh-TW).
@jed's locale and @mozilla's i18n-abide both have parsing code that takes region tags and even score into account.
E.g. https://github.com/mozilla/i18n-abide/blob/master/lib/i18n.js#L269-L295
Hope that helps!
The text was updated successfully, but these errors were encountered:
Just landed a pull request that fixes this.
Sorry, something went wrong.
No branches or pull requests
Currently line 224:
https://github.com/jeresig/i18n-node-2/blob/master/i18n.js#L224
This only grabs the language tag, not the region tag, so it doesn't differentiate between e.g. simplified Chinese (zh-CN) and traditional (zh-TW).
@jed's locale and @mozilla's i18n-abide both have parsing code that takes region tags and even score into account.
E.g. https://github.com/mozilla/i18n-abide/blob/master/lib/i18n.js#L269-L295
Hope that helps!
The text was updated successfully, but these errors were encountered: