-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UICollectionViewCell #4
Comments
Thanks @fabb - Yes, absolutely! That's why I named it generically as |
Right now a bit stressful, but if we'll do our planned refactoring in a few months to completely move from UITableView to UICollectionView, I'll point the one from our team doing it to this library. |
👍 |
Proof of concept for UICollectionView: https://github.com/mschonvogel/SwipeCellKit |
Hey @mschonvogel - Awesome!!! Thanks so much for putting this together! 🎉🙌 Looking forward to taking a closer look at this tonight! |
You're welcome! It was actually pretty straight forward. I'm curious about your ideas on how to make this library universally work for both, UICollectionView and UITableView. ✌️ |
Hey @mschonvogel - I was about to ask you the same question! 🤣 Having a working version for both will definitely help clarify how to decouple the generic components from each view specific implementation. It has also started to become clearer as I've refactored things while introducing other new features. |
Hey @jerkoch and @mschonvogel maybe we could do something like this? |
Hey @MarvinNazari - Thanks for sharing! 👍 I'm a big fan of @jessesquires work! |
I'm using the fork put together by @mschonvogel. It would be great if we could get that merged into the main project. I'd be happy to help if I can. Nice work by everyone! |
@ericreid How were you able to implement it? @mschonvogel's fork doesn't have any updates to the documentation to discuss UICollectionViewCell looks like. |
Can anyone explain how to make this work for CollectionView? |
Any update on this please? |
Has this been updated? I Really need to use it whit a collection view. |
Same here |
For everyone who want to use it with a collectionView, just use mschonvogel's brunch in your pod file, like so: |
It's more than a year later and you still didn't make UICollection support.. pure sadness. And no, we don't want to use a branch that is 66 commits with bug fixes behind the original. Please take the few hours you need for this to implement it. Such an awesome library and no collection view support. Does anyone even use UITableView still in 2018? |
@godexsoft this is open source. People work in their free time to provide things that help other people without charge. |
@fabb That is fine, but when there is an open PR (#142) that @kurabi said he would review over the next few days back on January 25th, with no updates since that is not open source. That is just not taking the time to maintain a project that you created. It's totally fine to work on things in your free time, and I get that is open source, but you always need someone to maintain it and put a decent amount of effort into it. Considering there is an open PR for this that @kurabi isn't addressing, @godexsoft is PERFECTLY in the right to be sad and frustrated about this. This is a major feature request, I mean this was issue/pr number 4. So it's obviously a highly requested feature. The maintainers and owners of this project need to layout guidelines and be clear about what needs to happen to that PR to get merged in and get this done. Obviously the community is willing to help build it to make it reality because there is already a PR for it... |
Thank you all for your input. The The project is actively maintained as one can see by previous releases. Just because this particular feature isn't being worked on it doesn't mean this project isn't being maintained. |
@kurabi Thank you very much. I know speaking for myself and I believe for many others we really appreciate your work on this code. If I get some time I'll try to look at your comments on that PR and maybe I'll get around to helping out at some point. |
Glad to see i triggered a bit of a shitstorm here :) maybe things will get done finally. |
This feature is now complete and has been merged onto master. #188. Thank you for all the contributed to this. Thank you to @kreeger @gcox and @mschonvogel. |
Nice library when wanting more than possible with
tableView(_:editActionsForRowAt:)
. Would it be possible to adopt this in order to work withUICollectionViewCell
?The text was updated successfully, but these errors were encountered: