Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add darktheme option to the settings page. #58

Closed
4 tasks done
jeroen1602 opened this issue Sep 27, 2020 · 0 comments · Fixed by #67
Closed
4 tasks done

Add darktheme option to the settings page. #58

jeroen1602 opened this issue Sep 27, 2020 · 0 comments · Fixed by #67
Assignees
@jeroen1602
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@jeroen1602
Copy link
Owner

jeroen1602 commented Sep 27, 2020 •
edited

Currently dark theme just copies it's state from the system, but this only works for Android 10+ and iOS 13+.

The user should be able to select their own preferred setting.

  • Add option for dark theme to the settings.
  • Add option for light theme to the settings.
  • Add option for use system default to the settings (Android 10+ and iOS 13+).
  • Use system default as default option, else fall back to light theme (?).

This is a continuation on #9 and #57.
@jeroen1602 jeroen1602 added the enhancement New feature or request label Sep 27, 2020
@jeroen1602 jeroen1602 added this to the v1.1.0 milestone Sep 28, 2020
@jeroen1602 jeroen1602 self-assigned this Sep 28, 2020
@jeroen1602 jeroen1602 mentioned this issue Sep 28, 2020
Merged
@jeroen1602 jeroen1602 mentioned this issue Sep 28, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeroen1602 jeroen1602

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Added an option for selecting the preferred theme jeroen1602/lighthouse_pm
1 participant
@jeroen1602