Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small dark theme fixes. #65

Closed
6 tasks done
jeroen1602 opened this issue Sep 28, 2020 · 5 comments · Fixed by #69
Closed
6 tasks done

Small dark theme fixes. #65

jeroen1602 opened this issue Sep 28, 2020 · 5 comments · Fixed by #69
Labels
bug Something isn't working
Milestone

Comments

@jeroen1602
Copy link
Owner

jeroen1602 commented Sep 28, 2020

Some things don't look nice yet because of hard coded colors.

  • The background color for the disabled extra actions buttons don't look right.
  • The selected color is almost invisible for:
    • The main device page.
    • The nicknames page.
    • The Vive Base stations ids.
  • Use light Github logo instead of dark one in section About on settings page.
@jeroen1602 jeroen1602 added the bug Something isn't working label Sep 28, 2020
@jeroen1602 jeroen1602 added this to the v1.1.0 milestone Sep 28, 2020
@mralext20
Copy link
Contributor

This is probably a similar case to the "we couldn't find any baseststions" text, wherein the color is set where the text/ button is made, and not as part of the theme

@jeroen1602
Copy link
Owner Author

Jep, still needs to be fixed though. But I thought I'd work on #65 first since it's easier to debug this one after.

Or do you want to handle this one?

@mralext20
Copy link
Contributor

i can give it a look.

@jeroen1602
Copy link
Owner Author

I've completed #58 with pr #67. So it should be a lot easier to change the theme than going into your system's settings.

@mralext20
Copy link
Contributor

mralext20 commented Sep 28, 2020

i was already using the quick settings title for flicking between them before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants