Implement the Iterator interface for the parser #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 3 changes (sorry, I just didn't plan that very well when making the changes; if you want, I can cherry-pick and split it into 3 separate PRs):
VCardParser::parseFromFile()
(throws an exception)getCards()
, which gets all cards. This is to complement thegetCardAtIndex()
method (which is great, but not sufficient).Iterator
interface to loop over parsed data. Let me detail this last one.Implement the Iterator interface for the parser class. This will allow parsed VCard databases to be easily iterated over. Example:
This is much more DX friendly than the simple
getCardAtIndex()
andgetCards()
methods. Added unit tests accordingly.