Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rio mac #17

Closed
wants to merge 3 commits into from
Closed

Rio mac #17

wants to merge 3 commits into from

Conversation

mpettis
Copy link
Contributor

@mpettis mpettis commented Oct 13, 2014

No description provided.

…ther than just numeric data, will plot y-coordinates equally spaced in order that they are input, with x-coordinates as the labels. Also allows user to control plot width and height, and defaults to use the whole width of the existing terminal as the width, and use half of the height.
… in callR function for escaping newline in bash script, otherwise did not work on bash in my mac. Please test to see if it works for other bash as well, but it should. 2: Changed creation of OUT and ERR tempfiles. As currently made, would create a file, and then append either .png or .err to the FILENAME in the bash script, and then would write to the filesnames with the new suffixes. But the mktemp command makes the un-suffixed files as well, and they never get cleaned up in the temp directory. Appending the .png and .err suffix in the inner mktemp command call fixes that (again, tested on a Mac).
@mpettis
Copy link
Contributor Author

mpettis commented Oct 13, 2014

Sorry, messed up on original pull request and messaging -- here is my original comment, few edits:
...
Two changes:

1: added triple backslash-n for newline in cat statement in callR function for escaping newline in bash script, otherwise did not work on bash in my mac. Please test to see if it works for other bash as well (like Linux), but it should. Not sure why it worked on bash in Linux, unless I've not kept up on escaping sequences.

2: Changed creation of OUT and ERR tempfiles. As currently made, would create a file, and then append either .png or .err to the FILENAME in the bash script, and then would write to the filenames with the new suffixes. But the mktemp command makes the un-suffixed files as well, and they never get cleaned up in the temp directory using the trap call. Appending the .png and .err suffix in the inner mktemp command call fixes that (again, tested on a Mac).

@mpettis
Copy link
Contributor Author

mpettis commented Oct 13, 2014

Err... I need to retract this pull request, as the mktemp command didn't quite pan out like I had thought. Will resubmit a better one soon.

@mpettis mpettis closed this Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant