Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database access should use PDO instead of mysql_ #20

Closed
jeroenrnl opened this issue Jul 16, 2012 · 1 comment
Closed

Database access should use PDO instead of mysql_ #20

jeroenrnl opened this issue Jul 16, 2012 · 1 comment
Assignees
@jeroenrnl
Labels
enhancement MySQL
Milestone
v0.9.2

Comments

@jeroenrnl
Copy link
Owner

Zoph is still using the "old" mysql_* functions to access the database. This should change to PDO. This will also make it possible to use other databases instead of MySQL.
@ghost ghost assigned jeroenrnl Jul 16, 2012
jeroenrnl added a commit that referenced this issue Nov 2, 2014
@jeroenrnl
Basic framework for PDO migration created
46df67f 
Created a basic framework consisting of a class db and a class query.

#20
jeroenrnl added a commit that referenced this issue Nov 2, 2014
@jeroenrnl
Added docblock documentation for changed files
d0a876d 
#20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Moved category::getTotalPhotoCount() to new db class
10b0752 
Also added code to add an array of parameters to a query. This useful
for, for example an WHERE ... IN (..., ..., ...) query.

Issue #20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Refactor Querybuilder code
ada7b3e 
Refactored some of the code from last commit for cleaner code.

Issue #20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Added LIMIT and ORDER BY functionality to Querybuilder
d6ae4c2 
Including unittests

Issue #20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Change category::getAutoCover() to new db
ae2d9cc 
- Also created a new getAutoCoverOrder() function, that for now exists
besides the old one, until all classes have moved to the new db.

Issue #20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Added GROUP BY clause to querybuilder
dfe8188 
Issue #20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Changed category::getDetails() to new db core
4fc6d23 
Also moved the generation of JOIN queries to restrict a query to only
the photos the currently logged in user is allowed to see into a
separate function.

Issue #20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Changed category::getByName() to new db
2ece772 
Issue #20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Moved category::getChildren() to new db
14aab75 
This partly fixes #58 (same change should be made for albums)
Issue #20
jeroenrnl added a commit that referenced this issue Nov 28, 2014
@jeroenrnl
Split query class into select and query to allow for other types of q…
fea2efa 
…ueries

Also refactored a bit to make things simpler and remove unused functions

Issue #20
jeroenrnl added a commit that referenced this issue Dec 26, 2014
@jeroenrnl
Changed category::getTopN() to new DB
bcd9a43 
Also changed zophTable::expandQueryForUser() to static (which it should
have been)

Issue #20
jeroenrnl added a commit that referenced this issue Dec 26, 2014
@jeroenrnl
Added INSERT functionality to new database
ecdfef0 
Issue #20
jeroenrnl added a commit that referenced this issue Dec 26, 2014
@jeroenrnl
Changed category::addPhoto() to new db code
943b35c 
Also removed the "alias" possibility from INSERT queries, because it
turned out it didn't work (and is not really necessary).

Changed a testcase as it turned out to generate an SQL error (which was
ignored by the "old" db code).

Issue #20
jeroenrnl added a commit that referenced this issue Dec 26, 2014
@jeroenrnl
Added code for DELETE queries to new db code
828f85c 
Issue #20
jeroenrnl added a commit that referenced this issue Dec 26, 2014
@jeroenrnl
Moved category::removePhoto() to new db
90eeaa0 
Issue #20
jeroenrnl added a commit that referenced this issue Dec 26, 2014
@jeroenrnl
Moved album::lookup() and album::addPhoto() to new db
a8f0c22 
Issue #20
jeroenrnl added a commit that referenced this issue Dec 26, 2014
@jeroenrnl
Move album::removePhoto() and album::getChildren() to new db
20407b4 
Issue #20
jeroenrnl added a commit that referenced this issue Dec 26, 2014
@jeroenrnl
Moved album::getTotalPhotoCount() to new db
c2a87a1 
Issue #20
jeroenrnl added a commit that referenced this issue Feb 8, 2015
@jeroenrnl
Moved album::getTopN(), album::getAll and album::getNewer() to new db
cd19742 
Issue #20
jeroenrnl added a commit that referenced this issue Feb 8, 2015
@jeroenrnl
Moved album::getCount() to new db
dd5c512 
Issue #20
jeroenrnl added a commit that referenced this issue Feb 8, 2015
@jeroenrnl
New db: Removed functionality to add fields during a JOIN as it was n…
d3a24cd 
…ever used

Issue #20
jeroenrnl added a commit that referenced this issue Feb 8, 2015
@jeroenrnl
Added more tests to person class
8da34df 
Issue #20
Issue #29
jeroenrnl added a commit that referenced this issue Mar 31, 2015
@jeroenrnl
Create a class for UPDATE queries and moved methods from person class…
4eb2ec0 
… to new db

Moved person::addPhoto() and person::removePhoto() to new db code

issue #20
jeroenrnl added a commit that referenced this issue Mar 31, 2015
@jeroenrnl
Moved person::delete() and person::getAutoCover() to new db
7a02732 
Issue #20
jeroenrnl added a commit that referenced this issue Mar 31, 2015
@jeroenrnl
Moved person::getDetails() and person::getTopN() to new db code
616f3bf 
- Split zophTable::addPhotoTableToQuery() into addRelationTableToQuery()
and addPhotoTableToQuery() to keep complexity down

- Fixed wrong test result

Issue #20
jeroenrnl added a commit that referenced this issue May 17, 2015
@jeroenrnl
Moved person::getAll(), photographer::getAll() and person::getWhereFo…
23f82af 
…rSearch() to new db code

Issue #20
jeroenrnl added a commit that referenced this issue May 17, 2015
@jeroenrnl
Moved person::getByName() into new db
1ea8b28 
Issue #20
jeroenrnl added a commit that referenced this issue Jun 29, 2015
@jeroenrnl
Changed several functions in photo object to new DB code
1f029ac 
Changed photo::lookup(), photo::getLastPersonPos(), photo::getAlbums()
and photo::getCategories() to new database code.

Issue #20
jeroenrnl added a commit that referenced this issue Jun 29, 2015
@jeroenrnl
Changed several functions in photo object to new DB code
274c930 
Changed photo::getPeople(), photo::getComments() to new database code.

Also, whitespace fixes

Issue #20
jeroenrnl added a commit that referenced this issue Jun 29, 2015
@jeroenrnl
Added HAVING clause to query builder
8065610 
Also whitespace fixes

Issue #20
jeroenrnl added a commit that referenced this issue Jun 29, 2015
@jeroenrnl
Moved photo::getNear() and place::getNear() to new db code
3d677c6 
Also: whitespace fixes and a small change in query object (var naming)

Issue #20
jeroenrnl added a commit that referenced this issue Jun 29, 2015
@jeroenrnl
Moved photo::getByName() and photo::getLanLon() to new db
f77e430 
Also, whitespace fixes

Issue #20
jeroenrnl added a commit that referenced this issue Jul 13, 2015
@jeroenrnl
Changed photo::getFromHash() amd photo::getTotalSize() to new db
3386b89 
Issue #20
jeroenrnl added a commit that referenced this issue Jul 13, 2015
@jeroenrnl
Changed functions in place object to new db
7cd4e92 
- Changed place::delete(), place::getChildren() to new db code
- Got rid of place::getChildrenForUser(), moved this function (back)
into getChildren()
- Also made this same change in category, person and album objects
- Reactivated failing testcases for place (which no longer fail with new
db code)
- removed get_sql_for_order() util function as it is no longer used
- many whitespace fixes

Issue #20
jeroenrnl added a commit that referenced this issue Jul 13, 2015
@jeroenrnl
Changed place::getPhotos(), place::getPhotoCount and place::getTotalP…
ffd30c6 
…hotoCount() to new db

Also some cleanup in place object

Issue #20
jeroenrnl added a commit that referenced this issue Jul 13, 2015
@jeroenrnl
Moved place::getAutoCover() To new db code
c3185d0 
Also some whitespace fixes & cleanup in album & category object

Issue #20
jeroenrnl added a commit that referenced this issue Jul 13, 2015
@jeroenrnl
Changed place::getDetails() to new db code
daed82a 
Issue #20
jeroenrnl added a commit that referenced this issue Jul 13, 2015
@jeroenrnl
Moved place::getByName(), place::getTopN(), place::getCount() to new db
e2720a5 
Moved place::getPhotographed back into place::getCount()

Issue #20
jeroenrnl added a commit that referenced this issue Jul 17, 2015
@jeroenrnl
Changed conf class to new db
434b379 
Issue #20

Also some whitespace fixes in database.inc.php
jeroenrnl added a commit that referenced this issue Jul 17, 2015
@jeroenrnl
Changed confItem class to new db
346cd60 
Issue #20

Also some whitespace fixes
jeroenrnl added a commit that referenced this issue Jul 17, 2015
@jeroenrnl
Added union query to new db code and moved photoRelation::getRelated(…
d1de75e 
…) to new db

Issue #20
jeroenrnl added a commit that referenced this issue Sep 3, 2015
@jeroenrnl
Changed zophTable::insert() to new db
c0951f9 
- Added some code to insert class to be able to retrieve last insert id
- Added possibility to use functions (such as now() and password()) in
  INSERT statements.
- Corrected a reversed order of 'expected' and 'actual' in
  groupPermissions test case.

Issue #20
jeroenrnl added a commit that referenced this issue Sep 3, 2015
@jeroenrnl
changed zophTable::update() and zophTable::delete() to new db code
39fc178 
Also some whitespace fixes and removed no longer used
zophTable::createConstraints()

Issue #20
jeroenrnl added a commit that referenced this issue Sep 3, 2015
@jeroenrnl
Changed zophTable::getRecords() to new db
84bf61a 
Issue #20
jeroenrnl added a commit that referenced this issue Sep 3, 2015
@jeroenrnl
Moved zophTreeTable::getChildren() to new DB
c5abbb4 
Also
- some whitespace fixes
- added a few missing access modifiers (public, private, protected)

Issue #20
jeroenrnl added a commit that referenced this issue Sep 3, 2015
@jeroenrnl
Changed several methods in user to new db
e9d4a8a 
user::get_groups(),
user::get_album_permissions()
user::get_permissions_for_photo()

Added possibility to query::addFields() to add fields with a table name
or alias

Added possibility to zophTable::expandQueryForUser() to pass a user
object (instead of using the currently logged on user).

Issue #20
jeroenrnl added a commit that referenced this issue Sep 3, 2015
@jeroenrnl
Changed point::getNext() and point::getPrev() to new DB code
ad62857 
...and some whitespace fixes.

Issue #20
jeroenrnl added a commit that referenced this issue Sep 6, 2015
@jeroenrnl
Changed track::delete() to new db code
e9cc468 
Issue #20
jeroenrnl referenced this issue Nov 2, 2015
@jeroenrnl
Changed last refences to old db code and removed database.inc.php
0ed92c0 
Issue#20
jeroenrnl added a commit that referenced this issue Nov 5, 2015
@jeroenrnl
Moved all the database classes into namespace 'db'
f79d834 
Also split up include.inc.php into include.inc.php and autoload.inc.php.

issue #20
jeroenrnl added a commit that referenced this issue Nov 5, 2015
@jeroenrnl
Removed some debugging code and improved logging
833054d 
Fixes #20
@jeroenrnl
Copy link
Owner Author

This transformation is now complete...

Funny, I actually worked on this for almost exactly a year :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeroenrnl jeroenrnl

Labels
enhancement MySQL
Projects
None yet
Milestone
v0.9.2
Development

No branches or pull requests
1 participant
@jeroenrnl