Added SOLRAD_behavior EstimateFromMean #345
Conversation
|
I love this, but the name is not good. Please add a better name instead of EstimateFromMean. |
|
I am not a native English speaker, so do you have any suggestions? |
|
neither am I, but since it's taking the average of the sunhours and the temperature, I'd propose something like EstimateFromSunHoursAndTemperature. Of course, update the descriptions in the language files as well. For context, at first I was going to close this because it seemed to do exactly what EstimateFromTemp does, but only after looking at the code I realized that is actually not what it does. Imagine the confusion ti the user or future developer if we don't give things good names. |
tefracky
force-pushed
the
add_EstimateFromMean
branch
from
c766daa
to
8b9a12a
Compare
|
It's done. I also fixed some markdown formatting in the Readme (tailing whitepaces and missing blank lines). |
| @@ -24,6 +24,7 @@ class SOLRAD_behavior(Enum): | |||
| EstimateFromTemp="1" | |||
| EstimateFromSunHours="2" | |||
| DontEstimate="3" | |||
| EstimateFromMean="4" | |||
There was a problem hiding this comment.
EstimateFromMean is not the right name. Let's give this a more descriptive name.
| @@ -143,7 +143,8 @@ | |||
| "translated-options": { | |||
| "DontEstimate": "Nicht berechnen", | |||
| "EstimateFromSunHours": "Basierend auf den Sonnenstunden", | |||
| "EstimateFromTemp": "Basierend auf der Temperatur" | |||
| "EstimateFromTemp": "Basierend auf der Temperatur", | |||
| "EstimateFromMean": "Basierend auf dem Mittelwert" | |||
There was a problem hiding this comment.
EstimateFromMean is not the right name. Let's give this a more descriptive name.
| @@ -143,7 +143,8 @@ | |||
| "translated-options": { | |||
| "DontEstimate": "Do not estimate", | |||
| "EstimateFromSunHours": "Estimate from sun hours", | |||
| "EstimateFromTemp": "Estimate from temperature" | |||
| "EstimateFromTemp": "Estimate from temperature", | |||
| "EstimateFromMean": "Estimate from mean" | |||
There was a problem hiding this comment.
EstimateFromMean is not the right name. Let's give this a more descriptive name.
Added a new possibility to calclate the solrad value. It is the mean value of the sun hours and the temperature and called EstimateFromMean. It shoult improve the accuracy of a calculated solrad value.