Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android does not have WebView.NavigationType.other #3

Closed
gunars opened this issue Mar 31, 2016 · 3 comments
Closed

Android does not have WebView.NavigationType.other #3

gunars opened this issue Mar 31, 2016 · 3 comments

Comments

@gunars
Copy link

gunars commented Mar 31, 2016

Problem:
On Android there is an error, because Android does not have WebView.NavigationType.other. Error message: "undefined is not an object (evaluating '_reactNative.WebView.NavigationType.other') Android does not have WebView.NavigationType.other there"

Solution:
in the showdown markdownview.js
onNavigationStateChange, should be like:

onNavigationStateChange(navState) {
// Check if user pressed on a link
if(navState.url !== 'about:blank' ) {
LinkingIOS.openURL(navState.url);
this.setState({
navigationStateChange: this.state.navigationStateChange + 1
});
}
}
@philohelp
Copy link

linkingIOS is deprecated and should be replaced by linking.

@donedgardo
Copy link

donedgardo commented Jun 25, 2016

I have made a pull request Pull request 9
#9

@jerolimov
Copy link
Owner

Thanks for the PR. I merged #7 which fixed this issue. If not please reopen the issue. Thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants