Merge 48ab4c0 into 560df91

.travis.yml

@@ -1,9 +1,10 @@
 language: node_js
 node_js:
   - 6.7.0
+services:
+  - xvfb
 before_script:
   - "export DISPLAY=:99.0"
-  - "sh -e /etc/init.d/xvfb start"
 script:
   - npm run ci
   - npm run lint

src/localstorage.js

@@ -114,7 +114,7 @@ export class LocalStorage {
   */
   destroy(model) {
     this._removeItem(this._itemName(model.id));
-    const newRecords = without(this.records, model);
+    const newRecords = without(this.records, model.id.toString());
 
     this.records = newRecords;
     this.save();

test/localstorage.test.js

@@ -422,6 +422,16 @@ describe('LocalStorage Collection', function() {
       expect(removed).to.be(null);
       expect(mySavedCollection.length).to.be(0);
     });
+
+    it('cleans up localStorage after destroying a model', function() {
+      const parsed = JSON.parse(item);
+      expect(localStorage.getItem('SavedCollection').split(',')).to.contain(parsed.id);
+
+      const newModel = mySavedCollection.get(parsed.id);
+      newModel.destroy();
+
+      expect(localStorage.getItem('SavedCollection').split(',')).to.not.contain(parsed.id);
+    });
   });
 
   describe('will fetch from localStorage if updated separately', function() {