Refactored tests, previous tests were not actually testing localStorage #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a model. Updated to Backbone 5.3
jeromegn
added a commit
that referenced
this pull request
Dec 28, 2011
Refactored tests, previous tests were not actually testing localStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored the tests to actually test every sync action of the persistence layer, the previous tests were just testing the collection (make changes to model in collection, test on model in collection). I also added tests for model specific Stores.
The previous tests also had a test that would fail, so I tweaked it. It was the test where you call
saveon a model and change the ID attribute. In practice, this actually clones the model in the persistence layer (saves based on ID), but changes it in the collection. You mustfetch()to refresh from the store for them to be synced. This seems more like a bug to me, so feel free to change the test.I also updated to Backbone 5.3