Remove isNew check on store.destroy #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renfredxh
changed the title
jeromegn
added a commit
that referenced
this pull request
Jun 13, 2014
Remove isNew check on store.destroy
|
Makes sense. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line that checks
model.isNew()causes and error when trying to store Backbone Collections. Collection objects do not have aisNewmethod so it fails when reaching this point.The check is unnecessary (it seems it wasn't put in for a specific reason other than to skip the rest of the method if the model hasn't been saved). The official Backbone implementation of sync doesn't have anything like this either.
If you'd rather keep it, we could put in something like
if (model.isNew !== undefined && model.isNew())to ensure it doesn't fail with collections.Side note: this was hard for me to debug because the block that was calling
destroyis incased in a try-catch that was swallowing the useful errors. Might be good to add aconsole.error(errorMessage)here