Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra stylesheets using css_files in config #84

Closed
wants to merge 215 commits into from

Conversation

peteruithoven
Copy link

See: #69
(Only tested with .documentup.js file)
Also ran tests, the first Markdown test failed, but that's probably not related.

jeromegn and others added 30 commits January 24, 2012 23:03
apostrophes are *never* correct for pluralization.
Add UTF-8 and annihilate type="text/javascript"
namspace localstorage calls to avoid issues when viewing multiple cached docs
@peteruithoven
Copy link
Author

Any feedback would be appreciated

@jeromegn
Copy link
Owner

Did you add a test for this? I know it's not the bet test setup on this project. This thing is old!

I'm not sure this would work out of the box, but maybe it does. I don't have the whole project's "flow" inside my head anymore :(

Edit: Feel free to fix the broken test.

@peteruithoven
Copy link
Author

I'll admit I didn't write a test, but I did test it.
I tested it by running DocumentUp locally and opening a test repository where I added stylesheets to the document up config file:
https://github.com/peteruithoven/DocumentUpTest
https://github.com/peteruithoven/DocumentUpTest/blob/master/.documentup.json
Because the config's from the file can so directly be used in the template there where not many changes for mistakes.

But I'll have a look at the tests

@peteruithoven
Copy link
Author

Fixing the current tests seems quite complicated: #86

@peteruithoven
Copy link
Author

I'm not sure how to add tests for this, I don't see any tests that check the outputted html or the template system in general.
Would it be an option to merge anyway?
(Not that this is your issue, but otherwise I need to host my fork temporarily somewhere else.)

@jeromegn
Copy link
Owner

Sorry about that. I have to close this. There's been a complete rewrite of the app.

Adding the functionality should be easier now.

However, I'm thinking it might be easier to specify a theme, and submit the theme as a PR.

@jeromegn jeromegn closed this Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet