New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra stylesheets using css_files in config #84
Conversation
apostrophes are *never* correct for pluralization.
"your" should be "you're"
Add UTF-8 and annihilate type="text/javascript"
namspace localstorage calls to avoid issues when viewing multiple cached docs
Fix typo in “GitHub”
Any feedback would be appreciated |
Did you add a test for this? I know it's not the bet test setup on this project. This thing is old! I'm not sure this would work out of the box, but maybe it does. I don't have the whole project's "flow" inside my head anymore :( Edit: Feel free to fix the broken test. |
I'll admit I didn't write a test, but I did test it. But I'll have a look at the tests |
Fixing the current tests seems quite complicated: #86 |
I'm not sure how to add tests for this, I don't see any tests that check the outputted html or the template system in general. |
Sorry about that. I have to close this. There's been a complete rewrite of the app. Adding the functionality should be easier now. However, I'm thinking it might be easier to specify a theme, and submit the theme as a PR. |
See: #69
(Only tested with .documentup.js file)
Also ran tests, the first Markdown test failed, but that's probably not related.