Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] A way to organize all highlights. #6

Open
kaifuj opened this issue Dec 1, 2019 · 4 comments
Open

[Feature Request] A way to organize all highlights. #6

kaifuj opened this issue Dec 1, 2019 · 4 comments
Assignees

Comments

@kaifuj
Copy link

kaifuj commented Dec 1, 2019

First, I really like this extension. It helps a lot while reading documentions. Thanks!

I think a overall panel (e.g. using options page) allowing organize or just simply view all highlights would be a great feature to have.

@jeromepl
Copy link
Owner

jeromepl commented Dec 1, 2019

Hi, thanks for your interest in this project!
I also think this would be a great addition, it's just a matter of finding the time to code it.

Here's a bit more detail for anyone (or my future self!) who wants to implement this.
Currently when un-highlighting something, the following things are stored:

  1. The original highlight
  2. Another highlight containing the selected region that the user wants to un-highlight

When loading highlights after a user re-opens that webpage, the highlights are applied in order and a highlight that is applied on top of an existing one has the effect of un-highlighting. Therefore we get the desired behavior.

However, what this means is that it is not super trivial to get all highlights on the page. When stuff was unhighlighted, simply reading all the highlights from storage there is no easy way to differentiate between a highlight and an "un-highlight".

@jeromepl
Copy link
Owner

In v3.0 you can now view a list of all highlights on the current page. However I am leaving this issue up since there seems to be some interest in having a list of all highlights no matter the page they are from. For example, and as suggested here, in an options page (when right-clicking the extension icon)

@jeromepl
Copy link
Owner

After v4, it is no longer possible to un-highlight part of a highlighted text. Users have to use the "delete" button instead.
This change simplifies the data storage a lot and will simplify development of features like this one here (except if we want to make it compatible with highlights stored pre v4)

@gudh
Copy link

gudh commented Jan 29, 2023

Is it possible to add an additional download button to export all the highlights to a file ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants