Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Button symbol is partially hidden when tab sizing is set to minimum width mode #6

Closed
brxtr opened this issue Oct 11, 2016 · 3 comments
Closed

Button symbol is partially hidden when tab sizing is set to minimum width mode #6

brxtr opened this issue Oct 11, 2016 · 3 comments
Labels
bug

Comments

@brxtr
Copy link

brxtr commented Oct 11, 2016 •
edited
Loading

Atom 1.10.2
one-light-ui 1.5.0
one-dark-ui 1.5.0

  • Set UI theme to One Light or One Dark (not sure if any other themes have tab sizing options)
  • Set Tab Sizing to Minimum

New tab button plus symbol appears to be partially hidden.
@brxtr brxtr changed the title Button shows dash symbol when tab sizing is set to minimum width mode Button symbol appears cut-off when tab sizing is set to minimum width mode Oct 11, 2016
@brxtr brxtr changed the title Button symbol appears cut-off when tab sizing is set to minimum width mode Button symbol is partially hidden when tab sizing is set to minimum width mode Oct 11, 2016
@jerone jerone added the bug label Oct 11, 2016
@jerone jerone closed this as completed in d71f65e Oct 11, 2016
@jerone
Copy link
Owner

jerone commented Oct 11, 2016

Thanks for reporting. New version 🚢ed.

@brxtr
Copy link
Author

brxtr commented Oct 11, 2016 •
edited
Loading

Thanks for looking at it. The icon is still slightly hidden for me:

New tab button

Are you seeing it differently?

Dropping each margin to 1.0em seems to fix it.

jerone added a commit that referenced this issue Oct 11, 2016
@jerone
🐛 Fix for One theme minimum mode. Fixes #6.
e8ebb18
@jerone
Copy link
Owner

jerone commented Oct 11, 2016

🐑

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jerone @brxtr