Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply experiments in the paper #17

Closed
3 tasks done
Tracked by #9
jerry871002 opened this issue Jul 20, 2023 · 2 comments · Fixed by #13
Closed
3 tasks done
Tracked by #9

Apply experiments in the paper #17

jerry871002 opened this issue Jul 20, 2023 · 2 comments · Fixed by #13
Assignees
Labels
clean up Remove unused components question Further information is needed refactor Improve code quality

Comments

@jerry871002
Copy link
Owner

jerry871002 commented Jul 20, 2023

There are only three experiments left in the latest version of the paper, add those three and remove the rest.

In this task, only make sure the new experiments work with the baseball environment, backward compatibility with the existing environments will be another task if needed.

@jerry871002 jerry871002 self-assigned this Jul 20, 2023
@jerry871002 jerry871002 linked a pull request Jul 20, 2023 that will close this issue
@jerry871002 jerry871002 changed the title Remove unused experiments Apply up-to-date experiments Jul 25, 2023
@jerry871002 jerry871002 added the question Further information is needed label Jul 25, 2023
@jerry871002
Copy link
Owner Author

@YY87927 you can leave your conclusion here after checking baseball_game_exp.py and #13.

@jerry871002 jerry871002 added refactor Improve code quality clean up Remove unused components labels Jul 31, 2023
@jerry871002
Copy link
Owner Author

I documented my conclusion here: https://jerry871002.github.io/bayesian-strategy-inference/experiment_definition/, could you take a look @YY87927?

@jerry871002 jerry871002 pinned this issue Aug 9, 2023
@jerry871002 jerry871002 changed the title Apply up-to-date experiments Apply experiments in the paper Aug 9, 2023
@jerry871002 jerry871002 unpinned this issue Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Remove unused components question Further information is needed refactor Improve code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants