Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

lemonorangeapple
Copy link

@lemonorangeapple lemonorangeapple commented Apr 8, 2024

此PR对本项目进行了汉化。

Copy link
Owner

@jerrychan7 jerrychan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常感谢你愿意花费时间来对此项目做出贡献。
i18n本身是一件工作量很大的任务,因此我一直下意识的逃避这方面的工作。但过去的经验告诉我i18n越早开始收益越大。因此我很高兴看到有人主动对这方面做出贡献。此次的pr是非常有意义的。
鉴于我本身母语就是中文,且翻译本身是很严谨的工作,请考虑我给出的改进意见。
我也不是专业翻译,欢迎对我提出的意见和建议进行讨论!

index.html Outdated Show resolved Hide resolved
@@ -7,14 +7,20 @@ class CreateNewWorldPage extends Page {
super();
this.typeBtn = this.shadowRoot.getElementById("world-type-btn");
this.typeEcho = this.shadowRoot.getElementById("world-type-echo");
this.typeEcho.data = "normal";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尽量不用在标准 DOM 的 Element 中添加自定义属性。
请改用在本类中添加属性或方法来完成相应的功能。

src/UI/pages/HowToPlayPage.html Outdated Show resolved Hide resolved
<tr><td><b>E</b></td> <td>Open inventory</td></tr>
<tr><td><b>Left/Right button</b></td> <td>Destroy/Place blocks</td></tr>
<tr><td><b>Scroll</b></td> <td>Scrolls through the Hotbar</td></tr>
<tr><td><b>WASD</b></td> <td>移动,双击W疾行</td></tr>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

分号是一种用于分隔存在一定关系的分句的标点符号,这些关系通常包括并列、转折、承接和因果等,尤其以并列关系为主。另一方面,官方翻译Sprint疾跑。建议改为移动;双击 W 疾跑

<tr><td><b>Scroll</b></td> <td>Scrolls through the Hotbar</td></tr>
<tr><td><b>WASD</b></td> <td>移动,双击W疾行</td></tr>
<tr><td><b>空格</b></td> <td>跳跃,按两下空格起飞</td></tr>
<tr><td><b>Shift/X</b></td> <td>起飞后,可降低高度</td></tr>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议改为在飞行模式中降低高度

<!-- <mc-slider id="render-distance" label="Render Distance: " unit=" chunks" step="1"></mc-slider> <mc-button>default</mc-button>
<br /> -->
<mc-slider id="fov" label="FOV: " unit=" °" step="1"></mc-slider> <mc-button>default</mc-button>
<mc-slider id="fov" label="视距: " unit=" " step="1"></mc-slider> <mc-button>default</mc-button>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. mc的官方翻译FOV视野
  2. 请保留视野的单位 °(角度,或者可以翻译成
  3. 请使用中文符号,而不是中英文符号混用!

<br />
<div class="homepage-blur-group">
<mc-slider id="homepage-blur" label="Homepage Blur: " unit=" px" min="0" step="0.5" max="10" value="3.5"></mc-slider> <mc-button>default</mc-button>
<mc-slider id="homepage-blur" label="主页透明度: " unit=" px" min="0" step="0.5" max="10" value="3.5"></mc-slider> <mc-button>default</mc-button>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此次应为主页模糊度

<li><mc-button gotoPage="setting">Setting</mc-button></li>
<li><mc-button gotoPage="select-world">开始</mc-button></li>
<li><mc-button gotoPage="how-to-play">帮助</mc-button></li>
<li><mc-button gotoPage="setting">设置</mc-button></li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请在此处添加个按钮,该按钮可以允许用户切换语言:默认显示是英语,用户可以在选择后切换成中文显示。
无法否认,英语是世界上最流行的语言之一,用英语作为默认语言可以使得大多数用户在第一次进入游戏时不会迷茫。
另一方面,已经有很多母语非中文的用户对项目进行了fork,如果默认语言变为中文将会造成不必要的混乱和困扰。
PS:我本来想将README也换成中英双语的,但无奈实在是没时间。我看到有些fork已经对README进行了英语翻译,但质量堪忧。

CNAME Outdated
@@ -0,0 +1 @@
mc.imjcj.cloudns.ph
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请删除和本项目无关的 CNAME 文件

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果可以请标明字体的来源。我本来想用 丁卯点阵字体 来作为本项目的像素字体的,但无奈该字体 实 在 是 太 贵 了!因此我只是简单的解包了非常旧版的mcpe找到了之前的字体(虽然也是非法的,但早期的mcpe本来也是非法的,就睁只眼闭只眼吧)

Copy link
Author

@lemonorangeapple lemonorangeapple May 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字体为GNU unifont点阵字体,使用SIL许可证,其大致意思为:

字体可以与任何软件捆绑、一并再分发和/或一并销售。

Copy link
Author

@lemonorangeapple lemonorangeapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已进行修改,感谢提出的意见与建议!

@lemonorangeapple lemonorangeapple changed the title Chinesized 98% Pages l10n May 25, 2024
@lemonorangeapple lemonorangeapple changed the title l10n i18n May 25, 2024
@lemonorangeapple
Copy link
Author

@jerrychan7 已对您提出的意见及建议进行了修改,望进行合并。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants